From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: kvm-13 Date: Wed, 21 Feb 2007 18:22:04 +0200 Message-ID: <45DC71AC.1090104@qumranet.com> References: <20070209081432.GG18296@rhun.ibm.com> <20070210040354.GU18296@rhun.ibm.com> <20070219223657.GM3513@rhun.ibm.com> <45DAA749.10909@qumranet.com> <20070221075035.GA2857@rhun.haifa.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Muli Ben-Yehuda Return-path: In-Reply-To: <20070221075035.GA2857-WD1JZD8MxeCTrf4lBMg6DdBPR1lH4CV8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Muli Ben-Yehuda wrote: > On Tue, Feb 20, 2007 at 09:46:17AM +0200, Avi Kivity wrote: > >> Muli Ben-Yehuda wrote: >> >>> Thanks for the analysis, this problem is understood. Avi commited a >>> fix for -14 a few days back, but the fix re-breaks >>> --kerneldir. Reenabling --kerneldir is simple - see attached patch - >>> but since this is obviously a fragile area, I decided not to push for >>> its inclusion. Maybe I'm the sole --kerneldir user :-) >>> >>> >>> >> I want --kerneldir to work; but as you say the build stuff is >> ridiculously fragile. >> >> How was this tested? >> > > I used this simple script to compare vanilla and patched and verified > the output is the same: > > Great. Applied, thanks. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV