* kvm-13
@ 2007-02-08 15:46 Omar Khan
[not found] ` <loom.20070208T163959-901-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
0 siblings, 1 reply; 11+ messages in thread
From: Omar Khan @ 2007-02-08 15:46 UTC (permalink / raw)
To: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f
hi,
"make install" does not install the modules in the right directory (actually
it is not making the 'extra' directory). I changed
KERNELDIR ?= /lib/modules/$(shell uname -r)/build
to
KERNELDIR := /lib/modules/$(shell uname -r)/build
in the kernel/Makefile and it is working now.
Omar
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier.
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
^ permalink raw reply [flat|nested] 11+ messages in thread[parent not found: <loom.20070208T163959-901-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>]
* Re: kvm-13 [not found] ` <loom.20070208T163959-901-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org> @ 2007-02-08 16:08 ` Muli Ben-Yehuda 2007-02-09 8:14 ` kvm-13 Muli Ben-Yehuda 1 sibling, 0 replies; 11+ messages in thread From: Muli Ben-Yehuda @ 2007-02-08 16:08 UTC (permalink / raw) To: Omar Khan; +Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f On Thu, Feb 08, 2007 at 03:46:25PM +0000, Omar Khan wrote: > hi, > > "make install" does not install the modules in the right directory (actually > it is not making the 'extra' directory). I changed > > KERNELDIR ?= /lib/modules/$(shell uname -r)/build > to > KERNELDIR := /lib/modules/$(shell uname -r)/build > > in the kernel/Makefile and it is working now. That will probably break --kerneldir again. I have to run now but I will look into it ASAP - I suspect the problem is elsewhere. Cheers, Muli ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: kvm-13 [not found] ` <loom.20070208T163959-901-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org> 2007-02-08 16:08 ` kvm-13 Muli Ben-Yehuda @ 2007-02-09 8:14 ` Muli Ben-Yehuda 2007-02-09 10:50 ` kvm-13 Omar Khan 1 sibling, 1 reply; 11+ messages in thread From: Muli Ben-Yehuda @ 2007-02-09 8:14 UTC (permalink / raw) To: Omar Khan; +Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f On Thu, Feb 08, 2007 at 03:46:25PM +0000, Omar Khan wrote: > hi, > > "make install" does not install the modules in the right > directory (actually it is not making the 'extra' directory). I > changed > > KERNELDIR ?= /lib/modules/$(shell uname -r)/build > to > KERNELDIR := /lib/modules/$(shell uname -r)/build > > in the kernel/Makefile and it is working now. - what does 'grep KERNELDIR config.mak' at the top level say after you've run configure? your change should not have any effect since KERNELDIR is set in config.mak to /lib/modules/$(shell uname -r)/build if --kerneldir is not specified. Did you do 'make install' without configuring and building first? - 'make install' seems pretty bogus, it relies on KERNELDIR ending in 'build', which is wrong for --kerneldir=xxx and it uses DESTDIR without ever setting it. What was DESTDIR supposed to do? any objections to removing it? Cheers, Muli ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: kvm-13 2007-02-09 8:14 ` kvm-13 Muli Ben-Yehuda @ 2007-02-09 10:50 ` Omar Khan [not found] ` <loom.20070209T114406-952-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org> 0 siblings, 1 reply; 11+ messages in thread From: Omar Khan @ 2007-02-09 10:50 UTC (permalink / raw) To: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f Muli Ben-Yehuda <muli@...> writes: > > On Thu, Feb 08, 2007 at 03:46:25PM +0000, Omar Khan wrote: > > hi, > > > > "make install" does not install the modules in the right > > directory (actually it is not making the 'extra' directory). I > > changed > > > > KERNELDIR ?= /lib/modules/$(shell uname -r)/build > > to > > KERNELDIR := /lib/modules/$(shell uname -r)/build > > > > in the kernel/Makefile and it is working now. > > - what does 'grep KERNELDIR config.mak' at the top level say after > you've run configure? your change should not have any effect since > KERNELDIR is set in config.mak to /lib/modules/$(shell uname > -r)/build if --kerneldir is not specified. Did you do 'make install' > without configuring and building first? > > - 'make install' seems pretty bogus, it relies on KERNELDIR ending in > 'build', which is wrong for --kerneldir=xxx and it uses DESTDIR > without ever setting it. What was DESTDIR supposed to do? any > objections to removing it? > > Cheers, > Muli > > ------------------------------------------------------------------------- > Using Tomcat but need to do more? Need to support web services, security? > Get stuff done quickly with pre-integrated technology to make your job easier. > Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo > http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 > I am using opensuse 10.2 and the build directory is linked to the default directory: lrwxrwxrwx 1 root root 43 Feb 7 01:29 /lib/modules/2.6.18.2-34-default/build -> /usr/src/linux-2.6.18.2-34-obj/i386/default so KERNELDIR get set to the default directory (KERNELDIR=$(readlink -f $kerneldir)) in configure I installed kvm-12 before this, could it have caused this? Omar ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <loom.20070209T114406-952-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>]
* Re: kvm-13 [not found] ` <loom.20070209T114406-952-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org> @ 2007-02-10 4:03 ` Muli Ben-Yehuda 2007-02-19 22:22 ` kvm-13 Omar Khan 0 siblings, 1 reply; 11+ messages in thread From: Muli Ben-Yehuda @ 2007-02-10 4:03 UTC (permalink / raw) To: Omar Khan; +Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f On Fri, Feb 09, 2007 at 10:50:36AM +0000, Omar Khan wrote: > I am using opensuse 10.2 and the build directory is linked to the default > directory: > > lrwxrwxrwx 1 root root 43 Feb 7 01:29 /lib/modules/2.6.18.2-34-default/build -> > /usr/src/linux-2.6.18.2-34-obj/i386/default > > so KERNELDIR get set to the default directory (KERNELDIR=$(readlink > -f $kerneldir)) in configure That does not explain why the change you made (from ?= to :=) made any difference. Could you send a full log of ./configure && make && make install with and without your change? Thanks, Muli ------------------------------------------------------------------------- Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier. Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642 ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: kvm-13 2007-02-10 4:03 ` kvm-13 Muli Ben-Yehuda @ 2007-02-19 22:22 ` Omar Khan [not found] ` <loom.20070219T230318-698-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org> 0 siblings, 1 reply; 11+ messages in thread From: Omar Khan @ 2007-02-19 22:22 UTC (permalink / raw) To: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f Muli Ben-Yehuda <muli@...> writes: > That does not explain why the change you made (from ?= to :=) made any > difference. Could you send a full log of ./configure && make && make > install with and without your change? > Well from what I have observed this makes a difference because in config.mak KERNELDIR=/usr/src/linux-2.6.18.2-34-obj/i386/default This gets included in the kernel/Makefile and when make reaches KERNELDIR ?= /lib/modules/$(shell uname -r)/build KERNELDIR is already set (to default) so it does not set it to /build. Now when it does INSTALLDIR = $(patsubst %/build, %/extra, $(KERNELDIR))) nothing gets replaced since there is no 'build' to replace. So nothing gets installed in /lib/modules/2.6.18.2-34-default/extra/ and hence modprobe fails. if I replace ?= with := it KERNELDIR is changed to /lib/modules/$(shell uname -r)/build and hence we get the INSTALLDIR for the /extra. I will try to send the log for ./configure , make , make install. Thanks Omar Khan ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <loom.20070219T230318-698-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>]
* Re: kvm-13 [not found] ` <loom.20070219T230318-698-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org> @ 2007-02-19 22:36 ` Muli Ben-Yehuda [not found] ` <20070219223657.GM3513-k73YwwB0fHlWk0Htik3J/w@public.gmane.org> 2007-02-21 0:58 ` kvm-13 richardvoigt-Re5JQEeQqe8AvxtiuMwx3w 1 sibling, 1 reply; 11+ messages in thread From: Muli Ben-Yehuda @ 2007-02-19 22:36 UTC (permalink / raw) To: Omar Khan; +Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f Thanks for the analysis, this problem is understood. Avi commited a fix for -14 a few days back, but the fix re-breaks --kerneldir. Reenabling --kerneldir is simple - see attached patch - but since this is obviously a fragile area, I decided not to push for its inclusion. Maybe I'm the sole --kerneldir user :-) Index: kernel/Makefile =================================================================== --- kernel/Makefile (revision 4457) +++ kernel/Makefile (working copy) @@ -1,4 +1,5 @@ -KERNELDIR := /lib/modules/$(shell uname -r)/build +include ../config.mak + KVERREL = $(patsubst /lib/modules/%/build,%,$(KERNELDIR)) DESTDIR= Index: configure =================================================================== --- configure (revision 4457) +++ configure (working copy) @@ -94,7 +94,7 @@ cat <<EOF > config.mak PREFIX=$prefix -KERNELDIR=$(readlink -f $kerneldir) +KERNELDIR="$kerneldir" WANT_MODULE=$want_module EOF ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <20070219223657.GM3513-k73YwwB0fHlWk0Htik3J/w@public.gmane.org>]
* Re: kvm-13 [not found] ` <20070219223657.GM3513-k73YwwB0fHlWk0Htik3J/w@public.gmane.org> @ 2007-02-20 7:46 ` Avi Kivity [not found] ` <45DAA749.10909-atKUWr5tajBWk0Htik3J/w@public.gmane.org> 0 siblings, 1 reply; 11+ messages in thread From: Avi Kivity @ 2007-02-20 7:46 UTC (permalink / raw) To: Muli Ben-Yehuda; +Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f Muli Ben-Yehuda wrote: > Thanks for the analysis, this problem is understood. Avi commited a > fix for -14 a few days back, but the fix re-breaks > --kerneldir. Reenabling --kerneldir is simple - see attached patch - > but since this is obviously a fragile area, I decided not to push for > its inclusion. Maybe I'm the sole --kerneldir user :-) > > I want --kerneldir to work; but as you say the build stuff is ridiculously fragile. How was this tested? -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <45DAA749.10909-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]
* Re: kvm-13 [not found] ` <45DAA749.10909-atKUWr5tajBWk0Htik3J/w@public.gmane.org> @ 2007-02-21 7:50 ` Muli Ben-Yehuda [not found] ` <20070221075035.GA2857-WD1JZD8MxeCTrf4lBMg6DdBPR1lH4CV8@public.gmane.org> 0 siblings, 1 reply; 11+ messages in thread From: Muli Ben-Yehuda @ 2007-02-21 7:50 UTC (permalink / raw) To: Avi Kivity; +Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f On Tue, Feb 20, 2007 at 09:46:17AM +0200, Avi Kivity wrote: > Muli Ben-Yehuda wrote: > >Thanks for the analysis, this problem is understood. Avi commited a > >fix for -14 a few days back, but the fix re-breaks > >--kerneldir. Reenabling --kerneldir is simple - see attached patch - > >but since this is obviously a fragile area, I decided not to push for > >its inclusion. Maybe I'm the sole --kerneldir user :-) > > > > > > I want --kerneldir to work; but as you say the build stuff is > ridiculously fragile. > > How was this tested? I used this simple script to compare vanilla and patched and verified the output is the same: onebuild () { ./configure --qemu-cc=gcc-3.4 $1 && echo "XXX configure done" && (cd kernel && make LINUX=~/kvm/linux-2.6 sync) && make echo "XXX installing..." sudo make install echo "XXX cleaning" make clean } make clean onebuild --kerneldir=/home/muli/iommu/calgary/obj.linux/ onebuild --kerneldir=/lib/modules/`uname -r`/build onebuild The patch I used is this one: Index: kernel/Makefile =================================================================== --- kernel/Makefile (revision 4461) +++ kernel/Makefile (working copy) @@ -1,4 +1,5 @@ -KERNELDIR := /lib/modules/$(shell uname -r)/build +include ../config.mak + KVERREL = $(patsubst /lib/modules/%/build,%,$(KERNELDIR)) DESTDIR= Index: configure =================================================================== --- configure (revision 4461) +++ configure (working copy) @@ -94,7 +94,7 @@ cat <<EOF > config.mak PREFIX=$prefix -KERNELDIR=$(readlink -f $kerneldir) +KERNELDIR=$kerneldir WANT_MODULE=$want_module EOF ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ^ permalink raw reply [flat|nested] 11+ messages in thread
[parent not found: <20070221075035.GA2857-WD1JZD8MxeCTrf4lBMg6DdBPR1lH4CV8@public.gmane.org>]
* Re: kvm-13 [not found] ` <20070221075035.GA2857-WD1JZD8MxeCTrf4lBMg6DdBPR1lH4CV8@public.gmane.org> @ 2007-02-21 16:22 ` Avi Kivity 0 siblings, 0 replies; 11+ messages in thread From: Avi Kivity @ 2007-02-21 16:22 UTC (permalink / raw) To: Muli Ben-Yehuda; +Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f Muli Ben-Yehuda wrote: > On Tue, Feb 20, 2007 at 09:46:17AM +0200, Avi Kivity wrote: > >> Muli Ben-Yehuda wrote: >> >>> Thanks for the analysis, this problem is understood. Avi commited a >>> fix for -14 a few days back, but the fix re-breaks >>> --kerneldir. Reenabling --kerneldir is simple - see attached patch - >>> but since this is obviously a fragile area, I decided not to push for >>> its inclusion. Maybe I'm the sole --kerneldir user :-) >>> >>> >>> >> I want --kerneldir to work; but as you say the build stuff is >> ridiculously fragile. >> >> How was this tested? >> > > I used this simple script to compare vanilla and patched and verified > the output is the same: > > Great. Applied, thanks. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: kvm-13 [not found] ` <loom.20070219T230318-698-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org> 2007-02-19 22:36 ` kvm-13 Muli Ben-Yehuda @ 2007-02-21 0:58 ` richardvoigt-Re5JQEeQqe8AvxtiuMwx3w 1 sibling, 0 replies; 11+ messages in thread From: richardvoigt-Re5JQEeQqe8AvxtiuMwx3w @ 2007-02-21 0:58 UTC (permalink / raw) To: Omar Khan; +Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f On 2/19/07, Omar Khan <okhan-e94Sedi4moU@public.gmane.org> wrote: > Muli Ben-Yehuda <muli@...> writes: > > > > That does not explain why the change you made (from ?= to :=) made any > > difference. Could you send a full log of ./configure && make && make > > install with and without your change? > > > > Well from what I have observed this makes a difference because in config.mak > > KERNELDIR=/usr/src/linux-2.6.18.2-34-obj/i386/default Because you passed the wrong path to configure --kerneldir= This probably should be stated more explicitly in the configure --help comment for kerneldir, which should make it clear that the path MUST be /lib/modules/*/build If it's not, not only will the module install fail, so will KVERREL! If you want the default behavior, configure without specifying --kerneldir, don't override the user's choice with the default. I use --kerneldir too. When I'm upgrading a kernel, there should be no need to reboot (changing uname) in order to build out-of-tree modules, I should be able to prebuild everything and reboot seamlessly. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV ^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2007-02-21 16:22 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-02-08 15:46 kvm-13 Omar Khan
[not found] ` <loom.20070208T163959-901-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2007-02-08 16:08 ` kvm-13 Muli Ben-Yehuda
2007-02-09 8:14 ` kvm-13 Muli Ben-Yehuda
2007-02-09 10:50 ` kvm-13 Omar Khan
[not found] ` <loom.20070209T114406-952-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2007-02-10 4:03 ` kvm-13 Muli Ben-Yehuda
2007-02-19 22:22 ` kvm-13 Omar Khan
[not found] ` <loom.20070219T230318-698-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2007-02-19 22:36 ` kvm-13 Muli Ben-Yehuda
[not found] ` <20070219223657.GM3513-k73YwwB0fHlWk0Htik3J/w@public.gmane.org>
2007-02-20 7:46 ` kvm-13 Avi Kivity
[not found] ` <45DAA749.10909-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-02-21 7:50 ` kvm-13 Muli Ben-Yehuda
[not found] ` <20070221075035.GA2857-WD1JZD8MxeCTrf4lBMg6DdBPR1lH4CV8@public.gmane.org>
2007-02-21 16:22 ` kvm-13 Avi Kivity
2007-02-21 0:58 ` kvm-13 richardvoigt-Re5JQEeQqe8AvxtiuMwx3w
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox