From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi@qumranet.com>
Subject: Re: minor device number request for /dev/kvm (kernel-based virtual
 machine)
Date: Thu, 01 Mar 2007 15:05:06 +0200
Message-ID: <45E6CF82.9090001@qumranet.com>
References: <45975F61.4070506@qumranet.com> <93C4769E3BED6B42B7203BD6F065654C08C5D6D3@dmoexc01.emea.cpqcorp.net> <45E6BFD0.1060003@qumranet.com> <Pine.LNX.4.61.0703011401370.23355@yvahk01.tjqt.qr>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "Mathiasen, Torben" <Torben.Mathiasen@hp.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	kvm-devel <kvm-devel@lists.sourceforge.net>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Return-path: <linux-kernel-owner+glk-linux-kernel-3=40m.gmane.org-S933276AbXCANHU@vger.kernel.org>
In-Reply-To: <Pine.LNX.4.61.0703011401370.23355@yvahk01.tjqt.qr>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: kvm.vger.kernel.org

Jan Engelhardt wrote:
> On Mar 1 2007 13:58, Avi Kivity wrote:
>   
>> fs/char_dev.c:
>>     
>>> int register_chrdev(unsigned int major, const char *name,
>>>            const struct file_operations *fops)
>>> {
>>> struct char_device_struct *cd;
>>> struct cdev *cdev;
>>> char *s;
>>> int err = -ENOMEM;
>>>
>>> cd = __register_chrdev_region(major, 0, 256, name);
>>>       
>> So misc minor numbers under 256 are not supported.
>>
>> What's the way out?  Increase the region size?  I don't know if that's safe.
>>     
>
> If it does not increase memory usage, then possibly:
>
>   __register_chrdev_region(major, 0, (~0U) & MINORMASK, name);
>                                   or (1<<MINORMASK)-1 if that's more clear
>
>   

I'm more worried about something in the chardev bowels not supporting 
 >8bit minors well.


-- 
error compiling committee.c: too many arguments to function