From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: strange error loading kvm module on latest FC6 kernel Date: Wed, 07 Mar 2007 09:00:06 +0200 Message-ID: <45EE62F6.3060300@qumranet.com> References: <1173241719.4317.5.camel@greg-linux.ncs.co.nz> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080304080603070109010707" Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Greg M Lee Return-path: In-Reply-To: <1173241719.4317.5.camel-nqhUBgQlnDodtexkPab+ZEgmxNRb6L7S@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is a multi-part message in MIME format. --------------080304080603070109010707 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Greg M Lee wrote: > Hi > updated to latest FC6 kernel yesterday ie 2.6.19-1.2911.6.5.fc6 > compiled kvm-15 from sourceforge this morning > chose the unpatched kernel instructions [ was this the right choice ?] > configure, make, make install all went fine (some warnings here and > there) > modprobe kvm-intel gave a bunch of errors in dmesg the first of which > was: SELinux: initialized (dev kvmfs, type kvmfs), not configured for > labeling > > Ouch. Anybody here know how to deal with that? > so I disabled SELinux > modprobe kvm-intel still gave a bunch of errors in dmesg: > > kvm_intel: Unknown symbol gfn_to_memslot > Try with the attached patch. Unfortunately you also have to reboot. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. --------------080304080603070109010707 Content-Type: text/x-patch; name="module-load-fix.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="module-load-fix.patch" commit c1a8557e1da6e7d8bf8f77cb1b47c077f5c2a67d Author: Avi Kivity Date: Mon Feb 26 16:29:43 2007 +0200 KVM: Fix bogus failure in kvm.ko module initialization A bogus 'return r' can cause an otherwise successful module load to fail. This both denies users the use of kvm, and it also denies them the use of their machine, as it leaves a filesystem registered with its callbacks pointing into now-freed module memory. Fix by returning a zero like a good module. Thanks to Richard Lucassen (?) for reporting the problem and for providing access to a machine which exhibited it. Signed-off-by: Avi Kivity diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c index e48b4d7..ca82ba3 100644 --- a/drivers/kvm/kvm_main.c +++ b/drivers/kvm/kvm_main.c @@ -2540,7 +2540,7 @@ static __init int kvm_init(void) bad_page_address = page_to_pfn(bad_page) << PAGE_SHIFT; memset(__va(bad_page_address), 0, PAGE_SIZE); - return r; + return 0; out: kvm_exit_debug(); --------------080304080603070109010707 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV --------------080304080603070109010707 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --------------080304080603070109010707--