[patch] KVM: mmu.c, change BUG_ON() to WARN_ON()

[patch] KVM: mmu.c, change BUG_ON() to WARN_ON()

[Ingo Molnar]

Subject: [patch] KVM: mmu.c, change BUG_ON() to WARN_ON()
From: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>

this triggered for me with the cr3 cache - do not crash the host, just 
warn about the condition. (Given that there is code after the BUG_ON() 
this was the anticipated behavior i suspect.)

Signed-off-by: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>

Index: linux/drivers/kvm/mmu.c
===================================================================
--- linux.orig/drivers/kvm/mmu.c
+++ linux/drivers/kvm/mmu.c
@@ -514,7 +514,7 @@ static void mmu_page_remove_parent_pte(s
 	int i;
 
 	if (!page->multimapped) {
-		BUG_ON(page->parent_pte != parent_pte);
+		WARN_ON(page->parent_pte != parent_pte);
 		page->parent_pte = NULL;
 		return;
 	}

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: [patch] KVM: mmu.c, change BUG_ON() to WARN_ON()

[Ingo Molnar]

> (Given that there is code after the BUG_ON() this was the anticipated 
> behavior i suspect.)

ignore this sentence - it wasnt a BUG_ON(1).

	Ingo

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

Re: [patch] KVM: mmu.c, change BUG_ON() to WARN_ON()

[Avi Kivity]

Ingo Molnar wrote:
> Subject: [patch] KVM: mmu.c, change BUG_ON() to WARN_ON()
> From: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
>
> this triggered for me with the cr3 cache - do not crash the host, just 
> warn about the condition. (Given that there is code after the BUG_ON() 
> this was the anticipated behavior i suspect.)
>
> Signed-off-by: Ingo Molnar <mingo-X9Un+BFzKDI@public.gmane.org>
>
> Index: linux/drivers/kvm/mmu.c
> ===================================================================
> --- linux.orig/drivers/kvm/mmu.c
> +++ linux/drivers/kvm/mmu.c
> @@ -514,7 +514,7 @@ static void mmu_page_remove_parent_pte(s
>  	int i;
>  
>  	if (!page->multimapped) {
> -		BUG_ON(page->parent_pte != parent_pte);
> +		WARN_ON(page->parent_pte != parent_pte);
>  		page->parent_pte = NULL;
>  		return;
>  	}
>   

Host memory is corrupted, I think we should at a minimum kill the guest 
to contain the damage.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV