From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch] KVM: mmu.c, change BUG_ON() to WARN_ON() Date: Mon, 12 Mar 2007 10:27:12 +0200 Message-ID: <45F50EE0.7090000@qumranet.com> References: <20070312074426.GA13373@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Ingo Molnar Return-path: In-Reply-To: <20070312074426.GA13373-X9Un+BFzKDI@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Ingo Molnar wrote: > Subject: [patch] KVM: mmu.c, change BUG_ON() to WARN_ON() > From: Ingo Molnar > > this triggered for me with the cr3 cache - do not crash the host, just > warn about the condition. (Given that there is code after the BUG_ON() > this was the anticipated behavior i suspect.) > > Signed-off-by: Ingo Molnar > > Index: linux/drivers/kvm/mmu.c > =================================================================== > --- linux.orig/drivers/kvm/mmu.c > +++ linux/drivers/kvm/mmu.c > @@ -514,7 +514,7 @@ static void mmu_page_remove_parent_pte(s > int i; > > if (!page->multimapped) { > - BUG_ON(page->parent_pte != parent_pte); > + WARN_ON(page->parent_pte != parent_pte); > page->parent_pte = NULL; > return; > } > Host memory is corrupted, I think we should at a minimum kill the guest to contain the damage. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV