From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: kvm-16 fails to compile on Kubuntu Edgy Date: Mon, 19 Mar 2007 08:43:43 +0200 Message-ID: <45FE311F.9020008@qumranet.com> References: <45FC8616.20108@spamfence.net> <45FD2B19.5040100@qumranet.com> <45FDA76C.6020604@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Martin Kaufmann To: Anthony Liguori Return-path: In-reply-to: <45FDA76C.6020604-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Anthony Liguori wrote: > > The definition of struct file_system_type.get_sb for 2.6.17 is: > > struct super_block *(*get_sb) (struct file_system_type *, int, > const char *, void *); > > So a slightly modified kvmfs_get_sb() is needed. I'm not sure how to > cope with this though since this #if guard isn't in > external-module-compat.h. I was under the impression that per-kernel > version defined were frowned upon in mainline code. > > What's the correct solution to this? > See the 'sync' target in kernel/Makefile. It looks like all that is necessary is to add the 2.6.17 case to external-module-compat.h. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV