From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 544345733A; Tue, 14 Jan 2025 09:04:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736845446; cv=none; b=KZW2Uh7L0VEcV69gOAEOThklEBX9/4dSphh47SjuO1rR/ZVNjxbRT+ARmrzT0LF/UsZmtUutU5JT9KLjvirLlMZ+3ODzckg74U+13VCC+oBrHaTHElDB+ojOW0fULpsvgqQZjnhRNuMh4OZZFJzSapetmQR1hPgkf9tcihmgQdg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736845446; c=relaxed/simple; bh=EIBRLup3DdLg88ltgNRkf2Ore6BJXeQXUhoDAkW5i7o=; h=MIME-Version:Date:From:To:Cc:Subject:In-Reply-To:References: Message-ID:Content-Type; b=inqPTOaDhBpRRxXCTuJnWYprHvSdmK6nfRBTa0ibdx80V+7qfT40tNFJdWfsl3DmDMt06v8Nzz/HqRggbPdKBFmHbyPHBQPk2sH5BjdTXaJDiXCBOS4yUsZb0sz+wQg6M3D4Ol/xuf53l2mkKY5I6Zs4ZQKDcPgES7kTbMCCuRA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=F6d+MR0v; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="F6d+MR0v" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 50E0wTxN018849; Tue, 14 Jan 2025 09:04:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:reply-to:subject:to; s=pp1; bh=uaWc4UUe13m2Bj4Yl/ThTvhOP308PpV5tSrgJP7qcyQ=; b=F6d+MR0vqryH bWzMx6SV4Qdj7XJK2AedfL83/29vgkYPcojQDjqNMYRkYW7MJ9Po5Wz606cJPnoe /4tMdxAgfM3E0am1oyDnuhqHEN72v9h91WWGSqkz0AkQ7Z3Bef0MNuVmXfGQVjeH /v43nctbYclAlOSdqyFkQJzQukkAcUuuat0nDxMsguzZ3pdhqJzLTu8QYGqErxIR wG08g/hma5/MmLY9GxxI9Jr7SlQYwzUXej65X/VyCzFWAWajvO/XVB7A5axkcIih 9zdrGh1J1/gxgfMhToy9bt3887dAHT27BSD+ARrKEcdyvZCXY4hYdLD5E5nbaJxh ZlfDPcfLag== Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4454a5c34w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Jan 2025 09:04:01 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 50E5FLD0017359; Tue, 14 Jan 2025 09:04:01 GMT Received: from smtprelay02.wdc07v.mail.ibm.com ([172.16.1.69]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4444fk2cav-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 14 Jan 2025 09:04:01 +0000 Received: from smtpav02.dal12v.mail.ibm.com (smtpav02.dal12v.mail.ibm.com [10.241.53.101]) by smtprelay02.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 50E93xWv32244310 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 14 Jan 2025 09:04:00 GMT Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 92B0558062; Tue, 14 Jan 2025 09:03:59 +0000 (GMT) Received: from smtpav02.dal12v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 2B95158051; Tue, 14 Jan 2025 09:03:59 +0000 (GMT) Received: from ltc.linux.ibm.com (unknown [9.5.196.140]) by smtpav02.dal12v.mail.ibm.com (Postfix) with ESMTP; Tue, 14 Jan 2025 09:03:59 +0000 (GMT) Precedence: bulk X-Mailing-List: kvm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Date: Tue, 14 Jan 2025 10:03:58 +0100 From: Harald Freudenberger To: Rorie Reyes Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, hca@linux.ibm.com, borntraeger@de.ibm.com, agordeev@linux.ibm.com, gor@linux.ibm.com, pasic@linux.ibm.com, jjherne@linux.ibm.com, alex.williamson@redhat.com, akrowiak@linux.ibm.com Subject: Re: [PATCH v1] s390/vfio-ap: Signal eventfd when guest AP configuration is changed Reply-To: freude@linux.ibm.com Mail-Reply-To: freude@linux.ibm.com In-Reply-To: <20250107183645.90082-1-rreyes@linux.ibm.com> References: <20250107183645.90082-1-rreyes@linux.ibm.com> Message-ID: <45d553cd050334029a6d768dc6639433@linux.ibm.com> X-Sender: freude@linux.ibm.com Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: c8Sm4e-hprzCyYV4f7ZtoOWdR5tUPYrr X-Proofpoint-ORIG-GUID: c8Sm4e-hprzCyYV4f7ZtoOWdR5tUPYrr X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 priorityscore=1501 suspectscore=0 phishscore=0 mlxlogscore=999 spamscore=0 impostorscore=0 clxscore=1011 lowpriorityscore=0 bulkscore=0 malwarescore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2501140074 On 2025-01-07 19:36, Rorie Reyes wrote: > In this patch, an eventfd object is created by the vfio_ap device > driver > and used to notify userspace when a guests's AP configuration is > dynamically changed. Such changes may occur whenever: > > * An adapter, domain or control domain is assigned to or unassigned > from a > mediated device that is attached to the guest. > * A queue assigned to the mediated device that is attached to a guest > is > bound to or unbound from the vfio_ap device driver. This can occur > either by manually binding/unbinding the queue via the vfio_ap > driver's > sysfs bind/unbind attribute interfaces, or because an adapter, domain > or > control domain assigned to the mediated device is added to or removed > from the host's AP configuration via an SE/HMC > > The purpose of this patch is to provide immediate notification of > changes > made to a guest's AP configuration by the vfio_ap driver. This will > enable > the guest to take immediate action rather than relying on polling or > some > other inefficient mechanism to detect changes to its AP configuration. > > Note that there are corresponding QEMU patches that will be shipped > along > with this patch (see vfio-ap: Report vfio-ap configuration changes) > that > will pick up the eventfd signal. > > Signed-off-by: Rorie Reyes > Reviewed-by: Anthony Krowiak > Tested-by: Anthony Krowiak > --- > drivers/s390/crypto/vfio_ap_ops.c | 52 ++++++++++++++++++++++++++- > drivers/s390/crypto/vfio_ap_private.h | 2 ++ > include/uapi/linux/vfio.h | 1 + > 3 files changed, 54 insertions(+), 1 deletion(-) > > diff --git a/drivers/s390/crypto/vfio_ap_ops.c > b/drivers/s390/crypto/vfio_ap_ops.c > index a52c2690933f..c6ff4ab13f16 100644 > --- a/drivers/s390/crypto/vfio_ap_ops.c > +++ b/drivers/s390/crypto/vfio_ap_ops.c > @@ -650,13 +650,22 @@ static void vfio_ap_matrix_init(struct > ap_config_info *info, > matrix->adm_max = info->apxa ? info->nd : 15; > } > > +static void signal_guest_ap_cfg_changed(struct ap_matrix_mdev > *matrix_mdev) > +{ > + if (matrix_mdev->cfg_chg_trigger) > + eventfd_signal(matrix_mdev->cfg_chg_trigger); > +} > + > static void vfio_ap_mdev_update_guest_apcb(struct ap_matrix_mdev > *matrix_mdev) > { > - if (matrix_mdev->kvm) > + if (matrix_mdev->kvm) { > kvm_arch_crypto_set_masks(matrix_mdev->kvm, > matrix_mdev->shadow_apcb.apm, > matrix_mdev->shadow_apcb.aqm, > matrix_mdev->shadow_apcb.adm); > + > + signal_guest_ap_cfg_changed(matrix_mdev); > + } > } > > static bool vfio_ap_mdev_filter_cdoms(struct ap_matrix_mdev > *matrix_mdev) > @@ -792,6 +801,7 @@ static int vfio_ap_mdev_probe(struct mdev_device > *mdev) > if (ret) > goto err_put_vdev; > matrix_mdev->req_trigger = NULL; > + matrix_mdev->cfg_chg_trigger = NULL; > dev_set_drvdata(&mdev->dev, matrix_mdev); > mutex_lock(&matrix_dev->mdevs_lock); > list_add(&matrix_mdev->node, &matrix_dev->mdev_list); > @@ -1860,6 +1870,7 @@ static void vfio_ap_mdev_unset_kvm(struct > ap_matrix_mdev *matrix_mdev) > get_update_locks_for_kvm(kvm); > > kvm_arch_crypto_clear_masks(kvm); > + signal_guest_ap_cfg_changed(matrix_mdev); > vfio_ap_mdev_reset_queues(matrix_mdev); > kvm_put_kvm(kvm); > matrix_mdev->kvm = NULL; > @@ -2097,6 +2108,10 @@ static ssize_t vfio_ap_get_irq_info(unsigned > long arg) > info.count = 1; > info.flags = VFIO_IRQ_INFO_EVENTFD; > break; > + case VFIO_AP_CFG_CHG_IRQ_INDEX: > + info.count = 1; > + info.flags = VFIO_IRQ_INFO_EVENTFD; > + break; > default: > return -EINVAL; > } > @@ -2160,6 +2175,39 @@ static int vfio_ap_set_request_irq(struct > ap_matrix_mdev *matrix_mdev, > return 0; > } > > +static int vfio_ap_set_cfg_change_irq(struct ap_matrix_mdev > *matrix_mdev, unsigned long arg) > +{ > + s32 fd; > + void __user *data; > + unsigned long minsz; > + struct eventfd_ctx *cfg_chg_trigger; > + > + minsz = offsetofend(struct vfio_irq_set, count); > + data = (void __user *)(arg + minsz); > + > + if (get_user(fd, (s32 __user *)data)) > + return -EFAULT; > + > + if (fd == -1) { > + if (matrix_mdev->cfg_chg_trigger) > + eventfd_ctx_put(matrix_mdev->cfg_chg_trigger); > + matrix_mdev->cfg_chg_trigger = NULL; > + } else if (fd >= 0) { > + cfg_chg_trigger = eventfd_ctx_fdget(fd); > + if (IS_ERR(cfg_chg_trigger)) > + return PTR_ERR(cfg_chg_trigger); > + > + if (matrix_mdev->cfg_chg_trigger) > + eventfd_ctx_put(matrix_mdev->cfg_chg_trigger); > + > + matrix_mdev->cfg_chg_trigger = cfg_chg_trigger; > + } else { > + return -EINVAL; > + } > + > + return 0; > +} > + > static int vfio_ap_set_irqs(struct ap_matrix_mdev *matrix_mdev, > unsigned long arg) > { > @@ -2175,6 +2223,8 @@ static int vfio_ap_set_irqs(struct > ap_matrix_mdev *matrix_mdev, > switch (irq_set.index) { > case VFIO_AP_REQ_IRQ_INDEX: > return vfio_ap_set_request_irq(matrix_mdev, arg); > + case VFIO_AP_CFG_CHG_IRQ_INDEX: > + return vfio_ap_set_cfg_change_irq(matrix_mdev, arg); > default: > return -EINVAL; > } > diff --git a/drivers/s390/crypto/vfio_ap_private.h > b/drivers/s390/crypto/vfio_ap_private.h > index 437a161c8659..37de9c69b6eb 100644 > --- a/drivers/s390/crypto/vfio_ap_private.h > +++ b/drivers/s390/crypto/vfio_ap_private.h > @@ -105,6 +105,7 @@ struct ap_queue_table { > * @mdev: the mediated device > * @qtable: table of queues (struct vfio_ap_queue) assigned to the > mdev > * @req_trigger eventfd ctx for signaling userspace to return a device > + * @cfg_chg_trigger eventfd ctx to signal AP config changed to > userspace > * @apm_add: bitmap of APIDs added to the host's AP configuration > * @aqm_add: bitmap of APQIs added to the host's AP configuration > * @adm_add: bitmap of control domain numbers added to the host's AP > @@ -120,6 +121,7 @@ struct ap_matrix_mdev { > struct mdev_device *mdev; > struct ap_queue_table qtable; > struct eventfd_ctx *req_trigger; > + struct eventfd_ctx *cfg_chg_trigger; > DECLARE_BITMAP(apm_add, AP_DEVICES); > DECLARE_BITMAP(aqm_add, AP_DOMAINS); > DECLARE_BITMAP(adm_add, AP_DOMAINS); > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h > index c8dbf8219c4f..a2d3e1ac6239 100644 > --- a/include/uapi/linux/vfio.h > +++ b/include/uapi/linux/vfio.h > @@ -671,6 +671,7 @@ enum { > */ > enum { > VFIO_AP_REQ_IRQ_INDEX, > + VFIO_AP_CFG_CHG_IRQ_INDEX, > VFIO_AP_NUM_IRQS > }; Rorie, this is to inform listeners on the host of the guest. The guest itself already sees this "inside" with uevents triggered by the AP bus code. Do you have a consumer for these events?