Re: [PATCH v1] s390/vfio-ap: Signal eventfd when guest AP configuration is changed

Anthony Krowiak
2025-02-11T20:24:12Z

On 2/11/25 10:02 AM, Rorie Reyes wrote:
>
> On 2/11/25 2:58 AM, Alexander Gordeev wrote:
>> On Thu, Feb 06, 2025 at 09:12:27AM -0500, Rorie Reyes wrote:
>>
>> Hi Rorie,
>>
>>> On 2/6/25 2:40 AM, Alexander Gordeev wrote:
>>>> On Wed, Feb 05, 2025 at 12:47:55PM -0500, Anthony Krowiak wrote:
>>>>>>> How this patch is synchronized with the mentioned QEMU series?
>>>>>>> What is the series status, especially with the comment from Cédric
>>>>>>> Le Goater [1]?
>>>>>>>
>>>>>>> 1.
>>>>>>> https://lore.kernel.org/all/20250107184354.91079-1-rreyes@linux.ibm.com/T/#mb0d37909c5f69bdff96289094ac0bad0922a7cce
>> ...
>>>>> I don't think that is what Alex was asking. I believe he is asking
>>>>> how the
>>>>> QEMU and kernel patch series are going to be synchronized.
>>>>> Given the kernel series changes a value in vfio.h which is used by
>>>>> QEMU, the
>>>>> two series need to be coordinated since the vfio.h file
>>>>> used by QEMU can not be updated until the kernel code is
>>>>> available. So these
>>>>> two sets of code have
>>>>> to be merged upstream during a merge window. which is different
>>>>> for the
>>>>> kernel and QEMU. At least I think that is what Alex is asking.
>>>> Correct.
>>>> Thanks for the clarification, Anthony!
>>> Tony, thank you for the back up!
>>>
>>> Alexander, is there anything else you need from my end for
>>> clarification?
>> The original question still stays - is it safe to pull this patch now,
>> before the corresponding QEMU change is integrated?

Alexander,

This patch has to be pulled before the QEMU patches are integrated. The
change to the
include/uapi/linux/vfio.h file needs to be merged before the QEMU
version of that file
can be generated for a QEMU build. I have given my r-b for this patch,
so I think it is
safe to pull it now.

>>
>> Thanks!
>
> If there are no other concerns from anyone else, and Tony is ok to
> sign off, then I would say it's safe to pull the patch.
>
> I do have a v2 of my QEMU changes that need to be reviewed so it would
> probably ok to pull the kernel patches now.
>
> QEMU v2 patches: [RFC PATCH v2 0/5] Report vfio-ap configuration changes
>
> Unless someone else has any concerns with my kernal changes?
>
> Thanks!
>
>