Re: KVM Bug with Windows 2000

[Daniel Hecken <dh-LcvzS2Pvy/8X0D0ZMPkEVw@public.gmane.org>]

Hello Avi,

it works with this patch. I got an Windows 2000 with an ACPI HAL which
can boot now.

Thanks

Daniel

PS. Have you applied this patch to KVM 17?

Avi Kivity schrieb:
> Daniel Hecken wrote:
>> Hello!
>>
>> I have installed Windows 2000 on KVM SVN snapshot 4539 and the module
>> from the git master branch. My Computer has an Intel Core 2 Duo and runs
>> an x86 distribution (Ubuntu Feisty with Kernel 2.6.20).
>>
>> After the installation without kvm I tried to start the image with kvm
>> and get the exception in the appendix.
>>
>>   
>
> Let me know if the attached patch fixes this.
>
> ------------------------------------------------------------------------
>
> diff --git a/drivers/kvm/vmx.c b/drivers/kvm/vmx.c
> index 55139e0..a721b60 100644
> --- a/drivers/kvm/vmx.c
> +++ b/drivers/kvm/vmx.c
> @@ -618,7 +618,7 @@ static void fix_pmode_dataseg(int seg, struct kvm_save_segment *save)
>  {
>  	struct kvm_vmx_segment_field *sf = &kvm_vmx_segment_fields[seg];
>  
> -	if (vmcs_readl(sf->base) == save->base) {
> +	if (vmcs_readl(sf->base) == save->base && (save->base & AR_S_MASK)) {
>  		vmcs_write16(sf->selector, save->selector);
>  		vmcs_writel(sf->base, save->base);
>  		vmcs_write32(sf->limit, save->limit);
>   



-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV