From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] SVM: forbid guest to execute monitor/mwait Date: Thu, 22 Mar 2007 12:42:28 +0200 Message-ID: <46025D94.8050606@qumranet.com> References: <20070321184700.GA20139@amd.com> <46023264.4010105@qumranet.com> <20070322095605.GB20139@amd.com> <46025528.5010707@qumranet.com> <20070322101729.GC20139@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Joerg Roedel Return-path: In-Reply-To: <20070322101729.GC20139-5C7GfCeVMHo@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Joerg Roedel wrote: > There is no danger for the host kernel but for the guest. If the > userspace sets the monitor bit the guest will receive an #UD when trying > to use it. And we don't want the guest to use it because it is not > virtualized yet. > So, isn't a simpler fix not to set the monitor bit in cpuid? The patch is correct, but I don't see why it's needed as any guest will check the cpuid bit before using monitor. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV