Re: [ANNOUNCE] kvm-17 release

[Carsten Emde <Carsten.Emde-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>]

Hi!

>> Actually, the above line can be preserved, if we move the previous line 
>> down by 1: Was it a simple race?
>> --- kvm_main-17.c	2007-03-24 02:09:00.000000000 +0100
>> +++ kvm_main.c	2007-03-24 04:10:59.000000000 +0100
>> [..]
>> -		vcpu->mmio_read_completed = 1;
>>   		emulate_instruction(vcpu, kvm_run, vcpu->mmio_fault_cr2, 0);
>> +		vcpu->mmio_read_completed = 1;
> As far as I understand, vcpu->mmio_read_completed indicates that read
> data is present in vcpu->mmio_data. If the flag isn't set,
> emulator_read_emulated() - which is called by emulate_instruction() -
> will try to read the data *again*. While that's supposed to be okay for
> ordinary memory, it might make memory mapped i/o devices fail.
> [..]
> Or did I get something wrong?
I was probably a bit too fast. The only proven fact is that the system 
no longer stops booting when the call to emulate_instruction() is 
removed. Before speculating further, I will study the situation in more 
detail in order to better understand where and why it hangs.


--
Carsten Emde <C.Emde-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org>

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV