From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Emde Subject: Re: [ANNOUNCE] kvm-17 release Date: Sat, 24 Mar 2007 14:25:56 +0100 Message-ID: <460526E4.4020905@osadl.org> References: <45FFE14F.6020808@qumranet.com> <4602D9D5.7060806@mr511.de> <46039EEA.4070504@qumranet.com> <46048C34.4080300@osadl.org> <46049B0C.40501@osadl.org> <460519A6.1020005@mr511.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Michael Riepe Return-path: In-Reply-To: <460519A6.1020005-0QoEqw4nQxo@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Hi! >> Actually, the above line can be preserved, if we move the previous line >> down by 1: Was it a simple race? >> --- kvm_main-17.c 2007-03-24 02:09:00.000000000 +0100 >> +++ kvm_main.c 2007-03-24 04:10:59.000000000 +0100 >> [..] >> - vcpu->mmio_read_completed = 1; >> emulate_instruction(vcpu, kvm_run, vcpu->mmio_fault_cr2, 0); >> + vcpu->mmio_read_completed = 1; > As far as I understand, vcpu->mmio_read_completed indicates that read > data is present in vcpu->mmio_data. If the flag isn't set, > emulator_read_emulated() - which is called by emulate_instruction() - > will try to read the data *again*. While that's supposed to be okay for > ordinary memory, it might make memory mapped i/o devices fail. > [..] > Or did I get something wrong? I was probably a bit too fast. The only proven fact is that the system no longer stops booting when the call to emulate_instruction() is removed. Before speculating further, I will study the situation in more detail in order to better understand where and why it hangs. -- Carsten Emde ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV