From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [ANNOUNCE] kvm-17 release Date: Sun, 25 Mar 2007 10:47:50 +0200 Message-ID: <46063736.8080300@qumranet.com> References: <45FFE14F.6020808@qumranet.com> <4602D9D5.7060806@mr511.de> <46039EEA.4070504@qumranet.com> <46048C34.4080300@osadl.org> <46049B0C.40501@osadl.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Carsten Emde Return-path: In-Reply-To: <46049B0C.40501-Q945KHDl0DbYtjvyW6yDsg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carsten Emde wrote: > Carsten Emde wrote: >> I then reverted to kvm-16 and repeated all upgrade changes until the >> problem occurred. The culprit was found to be >> [..] >> +#ifdef THIS_PREVENTS_FC6_FROM_BOOTING >> emulate_instruction(vcpu, kvm_run, vcpu->mmio_fault_cr2, 0); >> +#endif >> [..] > Actually, the above line can be preserved, if we move the previous > line down by 1: Was it a simple race? > > --- kvm_main-17.c 2007-03-24 02:09:00.000000000 +0100 > +++ kvm_main.c 2007-03-24 04:10:59.000000000 +0100 > @@ -1574,8 +1574,8 @@ > > if (kvm_run->mmio_completed) { > memcpy(vcpu->mmio_data, kvm_run->mmio.data, 8); > - vcpu->mmio_read_completed = 1; > emulate_instruction(vcpu, kvm_run, vcpu->mmio_fault_cr2, 0); > + vcpu->mmio_read_completed = 1; > } > > vcpu->mmio_needed = 0; > > It's just a different way of backing it out. With mmio_read_completed unset, the emulation will simply fail. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV