Re: [ANNOUNCE] kvm-17 release

Avi Kivity
2007-03-25T08:47:50Z

Carsten Emde wrote:
> Carsten Emde wrote:
>> I then reverted to kvm-16 and repeated all upgrade changes until the
>> problem occurred. The culprit was found to be
>> [..]
>> +#ifdef THIS_PREVENTS_FC6_FROM_BOOTING
>> emulate_instruction(vcpu, kvm_run, vcpu->mmio_fault_cr2, 0);
>> +#endif
>> [..]
> Actually, the above line can be preserved, if we move the previous
> line down by 1: Was it a simple race?
>
> --- kvm_main-17.c 2007-03-24 02:09:00.000000000 +0100
> +++ kvm_main.c 2007-03-24 04:10:59.000000000 +0100
> @@ -1574,8 +1574,8 @@
>
> if (kvm_run->mmio_completed) {
> memcpy(vcpu->mmio_data, kvm_run->mmio.data, 8);
> - vcpu->mmio_read_completed = 1;
> emulate_instruction(vcpu, kvm_run, vcpu->mmio_fault_cr2, 0);
> + vcpu->mmio_read_completed = 1;
> }
>
> vcpu->mmio_needed = 0;
>
>

It's just a different way of backing it out. With mmio_read_completed
unset, the emulation will simply fail.

--
error compiling committee.c: too many arguments to function