Re: [ANNOUNCE] kvm-17 release

Avi Kivity
2007-03-25T08:46:46Z

Carsten Emde wrote:
> Avi Kivity wrote:
>> Michael Riepe wrote:
>>> With respect to the Core Duo, this is the best release I've seen so
>>> far:
> Unfortunately, kvm-17 was less successful here. FC6 did not boot any
> longer after I upgraded from kvm-16 to kvm-17, so I was rather
> surprised when I read the above message.
>
> This is the test system:
> CPU: Intel(R) Core(TM)2 CPU 6600 @ 2.40GHz, Chipset: Intel 975X
>
> The exact problem was that FC6 stopped booting before under kvm-16 it
> would display the line
> IP route cache hash table entries: 4096 (order: 2, 16384 bytes)
>
> I then reverted to kvm-16 and repeated all upgrade changes until the
> problem occurred. The culprit was found to be
>
> --- kvm_main-17.c 2007-03-24 02:09:00.000000000 +0100
> +++ kvm_main.c 2007-03-24 02:56:15.000000000 +0100
> @@ -1575,7 +1575,9 @@
> if (kvm_run->mmio_completed) {
> memcpy(vcpu->mmio_data, kvm_run->mmio.data, 8);
> vcpu->mmio_read_completed = 1;
> +#ifdef THIS_PREVENTS_FC6_FROM_BOOTING
> emulate_instruction(vcpu, kvm_run, vcpu->mmio_fault_cr2, 0);
> +#endif
> }
>
> vcpu->mmio_needed = 0;
>

I've already reverted this optimization. I'd like to get it back, since
it is sound, but I don't yet understand why it caused the regression.

--
error compiling committee.c: too many arguments to function