From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Gregory Haskins" <ghaskins-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>
Subject: Re: QEMU PIC indirection patch for in-kernel APIC	work
Date: Wed, 04 Apr 2007 13:51:16 -0400
Message-ID: <46139F39.BA47.005A.0@novell.com>
References: <4610A6A9.BA47.005A.0@novell.com>
	<46134B74.1080004@qumranet.com> <4613B438.60107@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
To: "Anthony Liguori" <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>,
	"Avi Kivity" <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Return-path: <kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
In-Reply-To: <4613B438.60107-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
Content-Disposition: inline
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=kvm-devel>
List-Post: <mailto:kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
List-Help: <mailto:kvm-devel-request-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org?subject=subscribe>
Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
List-Id: kvm.vger.kernel.org

>>> On Wed, Apr 4, 2007 at 10:20 AM, in message <4613B438.60107-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>,
Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org> wrote: 
>
> The devices are already written to take a set_irq function.  Instead of 
> hijacking the emulated PIC device, I think it would be better if in 
> pc.c, we just conditionally created our PIC device that reflected to the 
> hypervisor and passed the appropriate function to the emulated hardware.
> 

When I first starting looking at the code, I was hoping to do exactly that.  But unfortunately it appears as though many devices call pic_set_irq() directly which is why I used the approach I did.  Take a look at qemu/hw/rt18139.c for an example. 


> Otherwise, to support all the other architectures, there's going to be a 
> lot of modifications.

Fully agree, which is why I waited for review before putting in all that work ;)

-Greg

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV