public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Leslie Mann <lmann-7al4MSP+J8o@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: kvm-18 breaks Cisco VPN on WinXP SP1
Date: Sun, 15 Apr 2007 15:42:08 +0300	[thread overview]
Message-ID: <46221DA0.1030901@qumranet.com> (raw)
In-Reply-To: <loom.20070410T003525-72-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

Leslie Mann wrote:
> FYI, a switch to rtl8139 from the default NE2000 nic has "cured" the problem
> under both kvm-18 and kvm-svn.
>   

The hint finally sank in, I was able to reproduce after switching to 
ne2k (I usually use rtl8139).  The attached patch (for kvm-18) fixes it 
for me.  Confirmation would be appreciated.

-- 
error compiling committee.c: too many arguments to function


[-- Attachment #2: kvm-pio-fix.patch --]
[-- Type: text/x-patch, Size: 379 bytes --]

diff --git a/kernel/kvm_main.c b/kernel/kvm_main.c
index 3e06c56..11a3cab 100644
--- a/kernel/kvm_main.c
+++ b/kernel/kvm_main.c
@@ -1729,6 +1729,11 @@ int kvm_setup_pio(struct kvm_vcpu *vcpu, struct kvm_run *run, int in,
 		return 0;
 	}
 
+	if (!count) {
+		kvm_arch_ops->skip_emulated_instruction(vcpu);
+		return 1;
+	}
+
 	now = min(count, PAGE_SIZE / size);
 
 	if (!down)

[-- Attachment #3: Type: text/plain, Size: 286 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

  parent reply	other threads:[~2007-04-15 12:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-27  2:47 kvm-18 breaks Cisco VPN on WinXP SP1 Leslie Mann
     [not found] ` <460885B2.7080907-7al4MSP+J8o@public.gmane.org>
2007-03-27  7:11   ` Avi Kivity
2007-03-28  0:55     ` Leslie Mann
     [not found]       ` <loom.20070328T025020-733-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2007-03-28  7:12         ` Avi Kivity
2007-03-29  3:02           ` Leslie Mann
     [not found]             ` <loom.20070329T043939-431-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2007-03-29  6:59               ` Avi Kivity
2007-03-30  1:12                 ` Leslie Mann
     [not found]                   ` <loom.20070330T030834-700-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2007-03-30  6:48                     ` Avi Kivity
2007-03-30  9:16                       ` Uri Lublin
2007-04-01 18:43                       ` Leslie Mann
     [not found]                         ` <loom.20070401T202531-319-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2007-04-02  8:51                           ` Avi Kivity
2007-04-02 13:44                             ` Leslie Mann
     [not found]                               ` <loom.20070402T151656-719-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2007-04-04 16:28                                 ` Avi Kivity
2007-04-05  8:57                                   ` Leslie Mann
2007-04-09 23:04                                     ` Leslie Mann
     [not found]                                       ` <loom.20070410T003525-72-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2007-04-10  6:37                                         ` Avi Kivity
2007-04-11  3:48                                           ` Leslie Mann
2007-04-15 12:42                                         ` Avi Kivity [this message]
2007-04-16  4:28                                           ` Leslie Mann
     [not found]                                     ` <loom.20070405T104629-941-eS7Uydv5nfjZ+VzJOa5vwg@public.gmane.org>
2007-04-12  8:37                                       ` Avi Kivity
     [not found]                                         ` <461DEFBA.8080907-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-04-13  6:55                                           ` Carsten Emde

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46221DA0.1030901@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=lmann-7al4MSP+J8o@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox