Re: [PATCH] Remove redundant MSR save/restore

Avi Kivity
2007-04-25T08:17:20Z

Dong, Eddie wrote:
> This patch is to remove the redundant MSR save/restore at lightweight VM
> EXIT time. With this patch VMX guest KB performance can increase 17-37%.
>

There is a similar patch already in kvm-20 (which takes a slightly
different approach of changing nr_good_msrs depending on the mode).

However, the part that hoists the software msr saving above the vmentry
loop is not in my tree, and it does look good. It also makes sense to
use software save/load for the msrs that only matter to userspace.

> (I only tested it on KVM-18 since the git tree still has problem in my
> side, but I'd like to post this earlier to collect more feedback)
> Thanks, eddie
>

Please let me know if I can do anything to help with the git problem. I
also suggest subscribing to kvm-commits so that you can see the work on
my tree.

Also, please post patches *both* inline and as attachments :) - inline
makes it easy to review and comment, and attachments to prevent mangling
(this only applies to those with broken mailers -- a normal mailer will
set the attachments content disposition to 'inline', which lets
thunderbird show it as normal text).

--
error compiling committee.c: too many arguments to function