Re: [PATCH] Remove heavy is_empty_shadow_page call.

Avi Kivity
2007-04-25T08:49:15Z

Michael Riepe wrote:
> Dong, Eddie wrote:
>
>> A minor patch to avoid heavy is_empty_shadow_page for release version.
>>
>>
>> diff --git a/drivers/kvm/mmu.c b/drivers/kvm/mmu.c
>> index e85b4c7..58fdd7b 100644
>> --- a/drivers/kvm/mmu.c
>> +++ b/drivers/kvm/mmu.c
>> @@ -52,11 +52,15 @@ static void kvm_mmu_audit(struct kvm_vcpu *vcpu,
>> const char *msg) {}
>> static int dbg = 1;
>> #endif
>>
>> +#if defined(MMU_DEBUG)
>> +#define ASSERT(x) do { } while (0)
>>
>
> I suppose you meant the opposite, !defined(...)?
>
> Why would anyone want to turn off assertions in debug mode?
>
>

Good catch. I committed a fix.

--
error compiling committee.c: too many arguments to function