Re: [PATCH] Remove heavy is_empty_shadow_page call.

Dong, Eddie
2007-04-25T08:45:42Z

O, yes typo at different tree porting time.

Michael Riepe wrote:
> Dong, Eddie wrote:
>> A minor patch to avoid heavy is_empty_shadow_page for release
>> version.
>>
>>
>> diff --git a/drivers/kvm/mmu.c b/drivers/kvm/mmu.c
>> index e85b4c7..58fdd7b 100644
>> --- a/drivers/kvm/mmu.c
>> +++ b/drivers/kvm/mmu.c
>> @@ -52,11 +52,15 @@ static void kvm_mmu_audit(struct kvm_vcpu *vcpu,
>> const char *msg) {} static int dbg = 1;
>> #endif
>>
>> +#if defined(MMU_DEBUG)
>> +#define ASSERT(x) do { } while (0)
>
> I suppose you meant the opposite, !defined(...)?
>
> Why would anyone want to turn off assertions in debug mode?
>
>> +#else
>> #define ASSERT(x)
>> \
>> if (!(x)) {
>> \
>> printk(KERN_WARNING "assertion failed %s:%d: %s\n", \
>> __FILE__, __LINE__, #x);
>> \
>> }
>> +#endif
>>
>> #define PT64_PT_BITS 9
>> #define PT64_ENT_PER_PAGE (1 << PT64_PT_BITS)
>>
>>
------------------------------------------------------------------------
-
>> This SF.net email is sponsored by DB2 Express
>> Download DB2 Express C - the FREE version of DB2 express and take
>> control of your XML. No limits. Just data. Click to get it now.
>> http://sourceforge.net/powerbar/db2/
>> _______________________________________________
>> kvm-devel mailing list
>> kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>> https://lists.sourceforge.net/lists/listinfo/kvm-devel