From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Michael Riepe <michael-0QoEqw4nQxo@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH] Remove heavy is_empty_shadow_page call.
Date: Wed, 25 Apr 2007 11:49:15 +0300 [thread overview]
Message-ID: <462F160B.9070504@qumranet.com> (raw)
In-Reply-To: <462F13E0.80104-0QoEqw4nQxo@public.gmane.org>
Michael Riepe wrote:
> Dong, Eddie wrote:
>
>> A minor patch to avoid heavy is_empty_shadow_page for release version.
>>
>>
>> diff --git a/drivers/kvm/mmu.c b/drivers/kvm/mmu.c
>> index e85b4c7..58fdd7b 100644
>> --- a/drivers/kvm/mmu.c
>> +++ b/drivers/kvm/mmu.c
>> @@ -52,11 +52,15 @@ static void kvm_mmu_audit(struct kvm_vcpu *vcpu,
>> const char *msg) {}
>> static int dbg = 1;
>> #endif
>>
>> +#if defined(MMU_DEBUG)
>> +#define ASSERT(x) do { } while (0)
>>
>
> I suppose you meant the opposite, !defined(...)?
>
> Why would anyone want to turn off assertions in debug mode?
>
>
Good catch. I committed a fix.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
prev parent reply other threads:[~2007-04-25 8:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-04-23 2:56 [PATCH] Lazy FPU for SVM Anthony Liguori
[not found] ` <462C2048.4040700-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2007-04-23 6:50 ` Avi Kivity
[not found] ` <462C574E.2030304-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-04-23 14:32 ` Anthony Liguori
[not found] ` <462CC380.5020405-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2007-04-24 10:39 ` Avi Kivity
[not found] ` <462DDE52.5040303-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-04-24 13:59 ` Anthony Liguori
[not found] ` <462E0D52.5000707-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2007-04-24 14:32 ` Avi Kivity
2007-04-25 8:03 ` [PATCH] Remove redundant MSR save/restore Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A01599D74-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-04-25 8:17 ` Avi Kivity
[not found] ` <462F0E90.8010307-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-04-25 8:53 ` Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A01599E01-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-04-25 9:28 ` Avi Kivity
2007-04-25 7:30 ` [PATCH] Remove heavy is_empty_shadow_page call Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A01599D2B-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-04-25 8:03 ` Avi Kivity
[not found] ` <462F0B40.9060109-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-04-25 8:09 ` Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A01599D87-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-04-25 8:20 ` Avi Kivity
2007-04-25 8:40 ` Michael Riepe
[not found] ` <462F13E0.80104-0QoEqw4nQxo@public.gmane.org>
2007-04-25 8:45 ` Dong, Eddie
2007-04-25 8:49 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=462F160B.9070504@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=michael-0QoEqw4nQxo@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox