From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Remove heavy is_empty_shadow_page call. Date: Wed, 25 Apr 2007 11:49:15 +0300 Message-ID: <462F160B.9070504@qumranet.com> References: <10EA09EFD8728347A513008B6B0DA77A01599D2B@pdsmsx411.ccr.corp.intel.com> <462F13E0.80104@mr511.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Michael Riepe Return-path: In-Reply-To: <462F13E0.80104-0QoEqw4nQxo@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Michael Riepe wrote: > Dong, Eddie wrote: > >> A minor patch to avoid heavy is_empty_shadow_page for release version. >> >> >> diff --git a/drivers/kvm/mmu.c b/drivers/kvm/mmu.c >> index e85b4c7..58fdd7b 100644 >> --- a/drivers/kvm/mmu.c >> +++ b/drivers/kvm/mmu.c >> @@ -52,11 +52,15 @@ static void kvm_mmu_audit(struct kvm_vcpu *vcpu, >> const char *msg) {} >> static int dbg = 1; >> #endif >> >> +#if defined(MMU_DEBUG) >> +#define ASSERT(x) do { } while (0) >> > > I suppose you meant the opposite, !defined(...)? > > Why would anyone want to turn off assertions in debug mode? > > Good catch. I committed a fix. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/