From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH] Add need_resched check before go to
	kvm_resched
Date: Wed, 25 Apr 2007 16:53:44 +0300
Message-ID: <462F5D68.4030700@qumranet.com>
References: <10EA09EFD8728347A513008B6B0DA77A01599EB3@pdsmsx411.ccr.corp.intel.com>
	<462F5C7E.7010605@codemonkey.ws>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
To: Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
Return-path: <kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
In-Reply-To: <462F5C7E.7010605-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum=kvm-devel>
List-Post: <mailto:kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
List-Help: <mailto:kvm-devel-request-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org?subject=subscribe>
Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
List-Id: kvm.vger.kernel.org

Anthony Liguori wrote:
> Dong, Eddie wrote:
>> A minor change to reduce vcpu_put/vcpu_load frequency (still base on
>> KVM-18). Not sure if you would like to see this?
>>
>> Signed-off-by: Yaozu Dong <eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
>>
>> --- vmx.old    2007-04-25 20:28:19.000000000 +0800
>> +++ vmx.new    2007-04-25 20:28:10.000000000 +0800
>> @@ -1945,7 +1945,8 @@
>>                  return -EINTR;
>>              }
>>  
>> -            kvm_resched(vcpu);
>> +            if ( need_resched() )
>> +                kvm_resched(vcpu);
>>              goto again;
>>          }
>>      }
>
> This should get moved to kvm_resched() since both VT/SVM would benefit 
> from this.
>

Good point.  I'll do it.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/