From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gregory Haskins" Subject: Re: [PATCH 4/5] KVM: Local-APIC interface cleanup Date: Thu, 26 Apr 2007 10:43:25 -0400 Message-ID: <46308235.BA47.005A.0@novell.com> References: <20070420030905.12408.40403.stgit@ghaskins-t60p.haskins.net> <20070420030926.12408.27637.stgit@ghaskins-t60p.haskins.net> <462B22AE.4090108@qumranet.com> <462C9EAE.BA47.005A.0@novell.com> <462DCD31.4030108@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Avi Kivity" Return-path: In-Reply-To: <462DCD31.4030108-atKUWr5tajBWk0Htik3J/w@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org >>> On Tue, Apr 24, 2007 at 5:26 AM, in message <462DCD31.4030108-atKUWr5tajBWk0Htik3J/w@public.gmane.org>, Avi Kivity wrote: > Gregory Haskins wrote: > > #include "diatribes/complexity.h" Hehe...ok, point taken. I will make the changes you recommended here: 1) leave cr8 state in VCPU 2) convert LAPIC abstraction from using a vtable to non-virtuals 3) handle LAPIC present/enabled in the abstraction using checks instead of function pointers. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/