Re: [PATCH/PFC 0/2] s390 host support

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Hollis Blanchard wrote:
> On Tue, 01 May 2007 09:43:57 +0300, Avi Kivity wrote:
>
>   
>> Hollis Blanchard wrote:
>>     
>>>> I think we can start the syscall based API (with compatibility ioctls
>>>> for x86),  now that we have all four archs looking at it.
>>>>         
>>> I was looking at refactoring the ioctl interface, but since we're
>>> dropping it then I'm glad I haven't put too much time into it. :)
>>>      
>>>       
>> Well, that's needed anyway.  The ioctl interface isn't going away.
>>     
>
> Maybe I misunderstood. When you said this:
>   
>> I think we can start the syscall based API (with compatibility ioctls
>> for x86),  now that we have all four archs looking at it.
>>     
>
> I thought you meant that all architectures would use the syscall
> interface, and x86 would only continue to support the ioctls as a legacy
> interface. In that case, I think kvm_main.c would basically need a rename
> to kvm_ioctl.c, and it would be built only for x86 so wouldn't need any
> portability.
>   

That is what I meant.  But we wouldn't want to duplicate all that code, 
would we?  The ioctl interface and the syscall interface have to call 
the same internal API, so at least some refactoring is needed.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/