From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH/RFC 5/9] s390 virtual console for guests Date: Fri, 11 May 2007 14:00:12 -0500 Message-ID: <4644BD3C.8040901@codemonkey.ws> References: <1178903957.25135.13.camel@cotte.boeblingen.de.ibm.com> <1178904960.25135.32.camel@cotte.boeblingen.de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , Christian Borntraeger , Martin Schwidefsky To: Carsten Otte Return-path: In-Reply-To: <1178904960.25135.32.camel-WIxn4w2hgUz3YA32ykw5MLlKpX0K8NHHQQ4Iyu8u01E@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org I think it would be better to use hvc_console as Xen now uses it too. Carsten Otte wrote: > + if (!MACHINE_IS_GUEST) > + return 0; > + register_external_interrupt(0x1234, guest_tty_ext_handler); > This is an interesting way to get input data from the console :-) How many interrupts does s390 support (the x86 only supports 256)? Can you afford to burn interrupts like this? Is there not a better way to assign interrupts such that conflict isn't an issue? Regards, Anthony Liguori ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/