From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: ABI change proposal before the 2.6.22 freeze Date: Sun, 13 May 2007 15:17:01 +0300 Message-ID: <464701BD.7050707@qumranet.com> References: <4643518D.BA47.005A.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Gregory Haskins Return-path: In-Reply-To: <4643518D.BA47.005A.0-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Gregory Haskins wrote: > (assuming that hasn't happened already?) > > One thing that would make my life easier going forward would be if we could separate out the interrupt related state from the [gs]et_sregs() calls. What I propose is that we make two new calls (say [gs]et_pic). For "level-0" mode this will be saving/restoring the 256-bit "userint" array. For other modes, it will be saving whatever is relevant for the APIC (registers, etc). The userspace code would be aware of which mode it is operating under anyway, since it has to enable the feature. > While we can slip in such a change to mainline, we're committed to supporting the current ABI for Fedora 7, so there's not much point. However, I don't see an issue. You could specify that when the feature is enabled, the irq state in get/set sregs is ignored, and the new functions are to be used. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/