From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 6/8] KVM: Adds support for real NMI injection on VMX processors Date: Mon, 14 May 2007 12:38:54 +0300 Message-ID: <46482E2E.90404@qumranet.com> References: <20070509023731.23443.86578.stgit@novell1.haskins.net> <20070509030340.23443.84153.stgit@novell1.haskins.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Gregory Haskins Return-path: In-Reply-To: <20070509030340.23443.84153.stgit-sLgBBP33vUGnsjUZhwzVf9HuzzzSOjJt@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Gregory Haskins wrote: > Signed-off-by: Gregory Haskins > --- > > drivers/kvm/vmx.c | 63 +++++++++++++++++++++++++++++++++++++++++++++++++---- > drivers/kvm/vmx.h | 3 +++ > 2 files changed, 61 insertions(+), 5 deletions(-) > > diff --git a/drivers/kvm/vmx.c b/drivers/kvm/vmx.c > index bee4831..1c99bc9 100644 > --- a/drivers/kvm/vmx.c > +++ b/drivers/kvm/vmx.c > @@ -1148,7 +1148,14 @@ static int vmx_vcpu_setup(struct kvm_vcpu *vcpu) > PIN_BASED_VM_EXEC_CONTROL, > PIN_BASED_EXT_INTR_MASK /* 20.6.1 */ > | PIN_BASED_NMI_EXITING /* 20.6.1 */ > + | PIN_BASED_VIRTUAL_NMI /* 20.6.1 */ > ); > + > + if (!(vmcs_read32(PIN_BASED_VM_EXEC_CONTROL) & PIN_BASED_VIRTUAL_NMI)) > + printk(KERN_WARNING "KVM: Warning - Host processor does " \ > + "not support virtual-NMI injection. Using IRQ " \ > + "method\n"); > Warning is too severe here. Things work (right?), there's nothing the user can do about it, and no need to alert kvm-devel. KERN_DEBUG is sufficient. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/