From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: "Dong, Eddie" <eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel <kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
Subject: Re: [PATCH] lighweight VM Exit
Date: Tue, 15 May 2007 10:39:15 +0300 [thread overview]
Message-ID: <464963A3.7090505@qumranet.com> (raw)
In-Reply-To: <10EA09EFD8728347A513008B6B0DA77A016FC1F2-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
Dong, Eddie wrote:
> Avi Kivity wrote:
>
>> Why not use hardware autoloading? Is it slower than software?
>>
>
> I believe HW is faster than SW, but the problem is that this kind of
> save/restore is
> only needed for heavy weight VM Exit in KVM. While HW doesn't provide an
> easy
> way to bypass these MSR save/restore for light weight VM Exit, we have
> to do
> that in SW.
>
k.
>
>> Otherwise looks good. Did you measure performance improvement? I
>> usually use user/test/vmexit.c from kvm-userspace.git.
>>
>>
>
> Yes, I tested RHEL5 64 bits guest, in my old Pentium 4 platform, I get
> 4.9%
> performance increasement using Kernel Builder as workload. In my 4 core
> Clovertown platform (Core 2 Duo), I get 5.4% performance increasement.
> 32 bits guest test didn't show regression either.
> Further improvement can be made base on this patch such as MSR_EFER
> virtualization.
>
> thx,eddie
>
> A slight revise per Christoph's comments.
>
You missed my comments regarding coding style.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
next prev parent reply other threads:[~2007-05-15 7:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-10 9:29 guest state leak into host Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A016AB9E3-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-05-13 10:51 ` Avi Kivity
[not found] ` <4646EDB3.6030602-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-14 14:57 ` [PATCH] lighweight VM Exit (was:RE: guest state leak into host) Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A016FBD91-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-05-14 15:14 ` [PATCH] lighweight VM Exit Avi Kivity
[not found] ` <46487CD7.8070408-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-14 15:34 ` Christoph Hellwig
2007-05-15 6:10 ` Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A016FC1F2-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-05-15 7:39 ` Avi Kivity [this message]
[not found] ` <464963A3.7090505-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-15 10:12 ` Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A016FC3CD-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-05-15 13:48 ` Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A016FC419-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-05-16 8:35 ` Avi Kivity
[not found] ` <464AC26D.8040901-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-16 15:23 ` Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A014E8AB2-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-05-16 15:40 ` Avi Kivity
[not found] <10EA09EFD8728347A513008B6B0DA77A014E8AB5@pdsmsx411.ccr.corp.intel.com>
[not found] ` <10EA09EFD8728347A513008B6B0DA77A014E8AB5-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-05-16 16:04 ` Avi Kivity
[not found] ` <464B2B89.3060009-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-17 14:22 ` Dong, Eddie
[not found] ` <10EA09EFD8728347A513008B6B0DA77A0174CB56-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-05-17 14:54 ` Avi Kivity
[not found] ` <464C6C96.9090202-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-17 15:56 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=464963A3.7090505@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox