Re: [PATCH 5/9] KVM: Adds ability to signal userspace using a file-descriptor

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Gregory Haskins wrote:
> Signed-off-by: Gregory Haskins <ghaskins-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>
> ---
>
>  drivers/kvm/kvm.h      |    1 +
>  drivers/kvm/kvm_main.c |   52 ++++++++++++++++++++++++++++++++++++++++++------
>  include/linux/kvm.h    |    1 +
>  3 files changed, 48 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h
> index 7b5d5e6..f5731c4 100644
> --- a/drivers/kvm/kvm.h
> +++ b/drivers/kvm/kvm.h
> @@ -333,6 +333,7 @@ struct kvm_vcpu_irq {
>  	int                  deferred;
>  	struct task_struct  *task;
>  	int                  guest_mode;
> +	int                  eventfd;
>   

Best to convert the fd to a filp when you install it.  This avoids the
conversion during runtime and allows you to do error checking earlier.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/