From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 5/9] KVM: Adds ability to signal userspace using a file-descriptor Date: Tue, 15 May 2007 10:45:18 +0300 Message-ID: <4649650E.2070102@qumranet.com> References: <20070515031217.9382.44999.stgit@novell1.haskins.net> <20070515031536.9382.16826.stgit@novell1.haskins.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Gregory Haskins Return-path: In-Reply-To: <20070515031536.9382.16826.stgit-sLgBBP33vUGnsjUZhwzVf9HuzzzSOjJt@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Gregory Haskins wrote: > Signed-off-by: Gregory Haskins > --- > > drivers/kvm/kvm.h | 1 + > drivers/kvm/kvm_main.c | 52 ++++++++++++++++++++++++++++++++++++++++++------ > include/linux/kvm.h | 1 + > 3 files changed, 48 insertions(+), 6 deletions(-) > > diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h > index 7b5d5e6..f5731c4 100644 > --- a/drivers/kvm/kvm.h > +++ b/drivers/kvm/kvm.h > @@ -333,6 +333,7 @@ struct kvm_vcpu_irq { > int deferred; > struct task_struct *task; > int guest_mode; > + int eventfd; > Best to convert the fd to a filp when you install it. This avoids the conversion during runtime and allows you to do error checking earlier. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/