From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: [PATCH/RFC 5/9] s390 virtual console for guests Date: Tue, 15 May 2007 09:54:45 +0200 Message-ID: <46496745.1030908@de.ibm.com> References: <1178903957.25135.13.camel@cotte.boeblingen.de.ibm.com> <4644BD3C.8040901@codemonkey.ws> <200705141823.13424.cborntra@de.ibm.com> <200705141848.18996.borntrae@de.ibm.com> <4648A11D.3050607@us.ibm.com> Reply-To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, mschwid2-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, borntrae-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org To: Anthony Liguori Return-path: In-Reply-To: <4648A11D.3050607-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Anthony Liguori wrote: > It seems like request_irq is roughly the same as > register_external_interrupt. I suspect that you could get away with > either patching hvc_console to use register_external_interrupt if > CONFIG_S390 or perhaps providing a common interface. > > I suspect that this is going to come up again for sharing other paravirt > drivers. Maybe we should have a wrappers for request_irq/free_irq in arch/ rather then #ifdefs in each paravirtual driver. We need to talk this over with Martin (our arch maintainer). so long, Carsten ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/