From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Gregory Haskins" Subject: Re: [PATCH 4/5] KVM: in-kernel-apic modification to QEMU Date: Wed, 16 May 2007 08:34:59 -0400 Message-ID: <464AC20A.BA47.005A.0@novell.com> References: <20070515031622.9468.4000.stgit@novell1.haskins.net> <20070515031800.9468.76001.stgit@novell1.haskins.net> <464AF035.9040405@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Avi Kivity" Return-path: In-Reply-To: <464AF035.9040405-atKUWr5tajBWk0Htik3J/w@public.gmane.org> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org >>> On Wed, May 16, 2007 at 7:51 AM, in message <464AF035.9040405-atKUWr5tajBWk0Htik3J/w@public.gmane.org>, Avi Kivity wrote: > Gregory Haskins wrote: >> @@ - 1045,7 +1054,7 @@ static CPUWriteMemoryFunc *ioapic_mem_write[3] = { >> ioapic_mem_writel, >> }; >> >> - IOAPICState *ioapic_init(void) >> +IOAPICState *ioapic_init(CPUState *env) >> { >> IOAPICState *s; >> int io_memory; >> @@ - 1054,6 +1063,7 @@ IOAPICState *ioapic_init(void) >> if (!s) >> return NULL; >> ioapic_reset(s); >> + s- >cpu_env = env; >> > > Is there actually a 1:1 correspondence between ioapics and vcpus? > > > While this would be highly unusual, there is nothing that prevents a system architect from doing so. In the case of the QEMU/KVM model, however, this is not true. There is one 1:1 relationship with the IOAPIC and the ISA bus, not per-vcpu. It looks like I might have coded this incorrectly. I will fix. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/