Re: [PATCH/RFC 5/9] s390 virtual console for guests

Arnd Bergmann
2007-05-15T00:27:34Z

On Monday 14 May 2007, Anthony Liguori wrote:
> It seems like request_irq is roughly the same as
> register_external_interrupt.  I suspect that you could get away with
> either patching hvc_console to use register_external_interrupt if
> CONFIG_S390 or perhaps providing a common interface.
>
> I suspect that this is going to come up again for sharing other paravirt
> drivers.

request_irq() is not a nice interface for s390, but it will probably make
sense to convert the two existing users of register_external_interrupt to
use that instead, in order to get something that can be shared across
architectures for virtual drivers.

It basically means extending struct ext_int_info_t to include a name and
a void* member that gets passed back to the interrupt handler, and to check
for invalid flags passed to request_irq.

You might want to show these in /proc/interrupts then as well,
as per-interrupt values.