Re: [PATCH] lighweight VM Exit

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Dong, Eddie wrote:
> Avi Kivity wrote:
>   
>>> Here it is.
>>>
>>>       
>> It's broken; your binutils is probably too old.
>>
>>
>>     
>>> Can u also send me your bootstrap and flat so that I can try here?
>>> Thx,eddie
>>>       
> Avi:
> 	Using yout vmexit.flat, it can work with my patch smoothly. Is
> this the one you see problems?
>   

Yes.  I'll try again, maybe there was some other issue.

Oh, I'm running with CONFIG_PREEMPT, maybe that's the cause.

> 	From the source of vmexit.flat, it is so simple (just do cpuid
> to test VM Exit cost) that I can't image it will cause problem with my
> patch since kernel build for both 32 on 64 and 64 on 64 work fine (with
>   
>> 1M VM Exit) with my patch.
>>     
>
> 	BTW, with following modification:
> diff --git a/user/Makefile b/user/Makefile
> diff --git a/user/flat.lds b/user/flat.lds
> index ff9693c..7dd922c 100644
> --- a/user/flat.lds
> +++ b/user/flat.lds
> @@ -8,6 +8,8 @@ SECTIONS
>      . = ALIGN(4K);
>      .data : { *(.data) }
>      . = ALIGN(16);
> +    .rodata : { *(.rodata) }
> +    . = ALIGN(16);
>      .bss : { *(.bss) }
>      . = ALIGN(4K);
>      edata = .;
>
>   

I applied this, thanks.

> 	I can get a looks like correct vmexit.flat at least for 64 bits.
> But i386 make test/vmexit.flat get following warning, is this normal?
>
> [root@vt32-pae user]# i386 make test/vmexit.flat
> gcc -I /root/avi/word/kvm-userspace/kernel/include -MMD -MF
> test/.vmexit.d -g -fomit-frame-pointer -Wall -m32 -nostdlib -o
> test/vmexit.flat -Wl,-T,flat.lds test/vmexit.o test/cstart.o
> test/printf.o
> /usr/bin/ld: warning: i386:x86-64 architecture of input file
> `test/vmexit.o' is incompatible with i386 output
> /usr/bin/ld: warning: i386:x86-64 architecture of input file
> `test/printf.o' is incompatible with i386 output
>   

You need to clean the old .o files first.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/