public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Hecken <dh-LcvzS2Pvy/8X0D0ZMPkEVw@public.gmane.org>
To: avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org,
	eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: 1 Bug found for compiling on 32 Bit machine
Date: Mon, 21 May 2007 09:47:12 +0200	[thread overview]
Message-ID: <46514E80.3080208@bahntechnik.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

Hello,

I have found an issue for compiling on 32 Bit machines in
v2.6.22-rc1-g1ab29f3.

I'm not sure if I have set the #ifdef CONFIG_X86_64 at the right place.
Please have a look at it. With this patch v2.6.22-rc1-g1ab29f3 compiles
und runs fine.

Daniel

[-- Attachment #2: vmx_32bit.patch --]
[-- Type: text/x-diff, Size: 992 bytes --]

	Signed-off-by: Daniel Hecken dh-LcvzS2Pvy/8X0D0ZMPkEVw@public.gmane.org 

--- my-kvm-tree/drivers/kvm/vmx.c	2007-05-21 09:19:41.000000000 +0200
+++ kvm-trunk/kernel/vmx.c	2007-05-21 09:35:05.000000000 +0200
@@ -41,7 +41,10 @@
 #else
 #define HOST_IS_64 0
 #endif
+
+#ifdef CONFIG_X86_64
 #define EFER_SAVE_RESTORE_BITS ((u64)EFER_SCE)
+#endif
 
 static struct vmcs_descriptor {
 	int size;
@@ -87,7 +90,9 @@
 
 static inline u64 msr_efer_save_restore_bits(struct vmx_msr_entry msr)
 {
+#ifdef CONFIG_X86_64
 	return (u64)msr.data & EFER_SAVE_RESTORE_BITS;
+#endif
 }
 
 static inline int msr_efer_need_save_restore(struct kvm_vcpu *vcpu)
@@ -279,6 +284,7 @@
 
 static void load_transition_efer(struct kvm_vcpu *vcpu)
 {
+#ifdef CONFIG_X86_64
 	u64 trans_efer;
 	int efer_offset = vcpu->msr_offset_efer;
 
@@ -288,6 +294,7 @@
 				vcpu->guest_msrs[efer_offset]);
 	wrmsrl(MSR_EFER, trans_efer);
 	vcpu->stat.efer_reload++;
+#endif
 }
 
 static void vmx_save_host_state(struct kvm_vcpu *vcpu)

[-- Attachment #3: Type: text/plain, Size: 286 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

             reply	other threads:[~2007-05-21  7:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-21  7:47 Daniel Hecken [this message]
     [not found] ` <46514E80.3080208-LcvzS2Pvy/8X0D0ZMPkEVw@public.gmane.org>
2007-05-21  8:30   ` 1 Bug found for compiling on 32 Bit machine Avi Kivity
     [not found]     ` <4651588A.1050808-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-21  9:07       ` Daniel Hecken
2007-05-23 11:40       ` Daniel Hecken
     [not found]         ` <4654281D.10806-LcvzS2Pvy/8X0D0ZMPkEVw@public.gmane.org>
2007-05-23 12:12           ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46514E80.3080208@bahntechnik.de \
    --to=dh-lcvzs2pvy/8x0d0zmpkevw@public.gmane.org \
    --cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
    --cc=eddie.dong-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox