From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC]kvm: swapout guest page Date: Mon, 21 May 2007 12:20:38 +0300 Message-ID: <46516466.9030904@qumranet.com> References: <288dbef70705210112t710bc904pe546840f7b9cfcfa@mail.gmail.com> <46516392.6070402@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Shaohua Li To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Return-path: In-Reply-To: <46516392.6070402-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carsten Otte wrote: > Shaohua Li wrote: > >> +EXPORT_SYMBOL(delete_from_swap_cache); >> +EXPORT_SYMBOL(move_to_swap_cache); >> +EXPORT_SYMBOL(lookup_swap_cache); >> +EXPORT_SYMBOL(read_swap_cache_async); >> +EXPORT_SYMBOL(get_swap_page); >> +EXPORT_SYMBOL(swap_free); >> +EXPORT_SYMBOL(add_to_page_cache_lru); >> > Use EXPORT_SYMBOL_GPL for all of these. > > I fail to see, why this is needed at all. Regular malloc()ed userspace > memory should be just what we want? The s390host prototype does just > that, userspace uses malloc() and the memory will be swapped out just > regular. Am I missing something important? > For one thing, kvm uses page->private to store its rmap information. This is lost if regular mappings are used. More importantly, both the regular address space and kvm will want to be called when a page is paged out, while this is doable, it isn't easy. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/