public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org
Cc: kvm-devel
	<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
	carsteno-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
	Shaohua Li <shaoh.li-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [RFC]kvm: swapout guest page
Date: Mon, 21 May 2007 16:31:30 +0300	[thread overview]
Message-ID: <46519F32.7020808@qumranet.com> (raw)
In-Reply-To: <465192DE.3000902-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>

Carsten Otte wrote:
> Avi Kivity wrote:
>> For one thing, kvm uses page->private to store its rmap information.  
>> This is lost if regular mappings are used.
>>
>> More importantly, both the regular address space and kvm will want to 
>> be called when a page is paged out, while this is doable, it isn't easy.
> Taking the long way to call kvm on pageout seems to be preferable. On 
> 390 we don't need any callback when a page is swapped out. Actually 
> the pte is invalidated and next time the guest accesses that page we 
> receive a page fault which causes us to swap it back in. Would you 
> explain why that callback is needed on x86?
>

The pte is stored/cached in two different places (in addition to what 
Linux already knows about):

- in the shadow page tables
- in the tlbs of the vcpus that may have referenced the page

so, when swapping out the page, you need to use the kvm rmap to find all 
shadow ptes which reference the page, and also IPI every processor that 
is running a vcpu belonging to the same virtual machine.

You also need to extend kvm rmap to contain read-only pages (as this 
patchset does).  That's a cost that may have a serious performance impact.

s390 uses the same pte for userspace virtual and guest physical?  that 
explains why a single invalidate suffices for both.  But aren't guest 
virtual translations cached in the tlb as well?

An example: suppose host pfn 7 is allocated as guest pfn 8 (and 
therefore, userspace address 0x8000).  Suppose further the guest maps 
guest pfn 8 to guest virtual 0x10000 and guest virtal 0x11000.  Aren't 
there three tlbs you need to shoot down?  host virtual 0x8000->pfn 7 and 
guest virual 0x10000->pfn 7 and 0x11000->pfn 7?

(Assuming page size is 4k)

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

  parent reply	other threads:[~2007-05-21 13:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-21  8:12 [RFC]kvm: swapout guest page Shaohua Li
     [not found] ` <288dbef70705210112t710bc904pe546840f7b9cfcfa-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-05-21  8:43   ` Dor Laor
2007-05-21  9:17   ` Carsten Otte
     [not found]     ` <46516392.6070402-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-05-21  9:20       ` Avi Kivity
     [not found]         ` <46516466.9030904-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-21 12:38           ` Carsten Otte
     [not found]             ` <465192DE.3000902-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-05-21 13:31               ` Avi Kivity [this message]
     [not found]                 ` <46519F32.7020808-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-21 14:07                   ` Carsten Otte
     [not found]                     ` <4651A7A4.9040702-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-05-21 14:35                       ` Avi Kivity
     [not found]                         ` <4651AE3F.8060603-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-21 14:41                           ` Carsten Otte
     [not found]                             ` <4651AFA6.2060605-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-05-21 14:43                               ` Avi Kivity
     [not found]                                 ` <4651AFF7.2080107-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-05-22 15:10                                   ` Carsten Otte
2007-05-21 11:51       ` Christoph Hellwig
2007-05-21  9:17   ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46519F32.7020808@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=carsteno-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
    --cc=carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=shaoh.li-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox