Re: [PATCH/RFC 5/9] s390 virtual console for guests

Christian Bornträger
2007-05-11T19:42:11Z

On Friday 11 May 2007 21:00, Anthony Liguori wrote:

> I think it would be better to use hvc_console as Xen now uses it too.

I dont know hvc_console, but I will have a look at it.

> Carsten Otte wrote:
> > + if (!MACHINE_IS_GUEST)
> > + return 0;
> > + register_external_interrupt(0x1234, guest_tty_ext_handler);
> >
>
> This is an interesting way to get input data from the console :-) How
> many interrupts does s390 support (the x86 only supports 256)? Can you
> afford to burn interrupts like this? Is there not a better way to
> assign interrupts such that conflict isn't an issue?

On s390 we have a 16 bit interrupt code, so we actually have plenty of
numbers... But, yes its a very good point, burning interrupts wont work
cross-platform.

Our patches are prototypes and need rework anyway. Take these patches as
discussion contribution in the spirit of release early. :-)

cheers

Christian