From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Hecken Subject: Re: 1 Bug found for compiling on 32 Bit machine Date: Wed, 23 May 2007 13:40:13 +0200 Message-ID: <4654281D.10806@bahntechnik.de> References: <46514E80.3080208@bahntechnik.de> <4651588A.1050808@qumranet.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070707060602020906060905" Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Avi Kivity Return-path: In-Reply-To: <4651588A.1050808-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is a multi-part message in MIME format. --------------070707060602020906060905 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Avi Kivity schrieb: > Daniel Hecken wrote: >> Hello, >> >> I have found an issue for compiling on 32 Bit machines in >> v2.6.22-rc1-g1ab29f3. >> >> I'm not sure if I have set the #ifdef CONFIG_X86_64 at the right place. >> Please have a look at it. With this patch v2.6.22-rc1-g1ab29f3 compiles >> und runs fine. >> >> > > v2.6.22-rc1-170-ga6935db compiles fine here. Can you double-check? > Hello Avi, as we discovered on IRC EFER_SCE is only defined below 2.6.22 in include/asm-i386/msr-index.h or include/asm-386/msr.h so I made a patch for external-module-compat.h. I hope I defined it in the right way. Daniel --------------070707060602020906060905 Content-Type: text/x-diff; name="external-module-compat.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="external-module-compat.patch" --- kvm-trunk/kernel/external-module-compat.h 2007-05-23 13:28:47.000000000 +0200 +++ kvm-trunk_old/kernel/external-module-compat.h 2007-05-23 11:01:54.000000000 +0200 @@ -151,3 +151,17 @@ #define CPU_DEAD_FROZEN (CPU_DEAD | CPU_TASKS_FROZEN) #endif + +#if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,22) + +#ifndef _EFER_SCE +#define _EFER_SCE 0 /* SYSCALL/SYSRET */ +#endif + +#ifndef EFER_SCE +#define EFER_SCE (1<<_EFER_SCE) +#endif + +#endif + + --------------070707060602020906060905 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ --------------070707060602020906060905 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --------------070707060602020906060905--