From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: 1 Bug found for compiling on 32 Bit machine Date: Wed, 23 May 2007 15:12:47 +0300 Message-ID: <46542FBF.6020102@qumranet.com> References: <46514E80.3080208@bahntechnik.de> <4651588A.1050808@qumranet.com> <4654281D.10806@bahntechnik.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Daniel Hecken Return-path: In-Reply-To: <4654281D.10806-LcvzS2Pvy/8X0D0ZMPkEVw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Daniel Hecken wrote: > Avi Kivity schrieb: > >> Daniel Hecken wrote: >> >>> Hello, >>> >>> I have found an issue for compiling on 32 Bit machines in >>> v2.6.22-rc1-g1ab29f3. >>> >>> I'm not sure if I have set the #ifdef CONFIG_X86_64 at the right place. >>> Please have a look at it. With this patch v2.6.22-rc1-g1ab29f3 compiles >>> und runs fine. >>> >>> >>> >> v2.6.22-rc1-170-ga6935db compiles fine here. Can you double-check? >> >> > > > Hello Avi, > > as we discovered on IRC EFER_SCE is only defined below 2.6.22 in > include/asm-i386/msr-index.h or include/asm-386/msr.h so I made a patch > for external-module-compat.h. I hope I defined it in the right way. > Looks good. Applied & thanks. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/