Re: [PATCH 10/10] KVM: Adds support for halting in the kernel

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Gregory Haskins wrote:
> Halting in userspace requires a relatively cumbersome mechanism to signal the
> halted VCPU.  Implementing halt in kernel should be relatively straight
> forward and it eliminates the need for the signaling
>
>  /*
> + * The vCPU has executed a HLT instruction with in-kernel mode enabled.
> + */
> +static int kvm_vcpu_kern_halt(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run)
> +{
> +	DECLARE_WAITQUEUE(wait, current);
> +	sigset_t sigblocked, sigsaved;
> +	int r = 1;
> +
> +	/*
> +	 * Unmask all signals while we wait
> +	 */
> +	memset(&sigblocked, 0, sizeof(sigblocked));
> +	sigprocmask(SIG_SETMASK, &sigblocked, &sigsved);
>   

We have a specialized signal mask for the kernel, and it is already in 
effect here.  See KVM_SET_SIGNAL_MASK.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/