Re: [PATCH 1/3] KVM paravirt_ops infrastructure

Andi Kleen
2007-05-31T10:40:19Z

On Thursday 31 May 2007 12:11:16 Ingo Molnar wrote:
>
> * Andi Kleen <ak-l3A5Bk7waGM@public.gmane.org> wrote:
>
> >
> > > > + if (wrmsr_safe(MSR_KVM_API_MAGIC, __pa(para_state), 0)) {
> > > > + printk(KERN_INFO "KVM guest: WRMSR probe failed.\n");
> > > > + return -ENOENT;
> > > > + }
> > >
> > > How about printk(KERN_INFO "I am not a KVM guest\n");?
> >
> > Actually paravirt probes that fail should be silent; similar like
> > drivers that don't find their hardware should do the same. Otherwise
> > if there are later distro kernels with various of those compiled in
> > the boot log would become quite noisy
>
> yeah. I suspect printing that it's executing in native mode is OK.

But only a single printk for that please

-Andi