From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: [PATCH RFC 3/3] virtio infrastructure: example block driver Date: Mon, 04 Jun 2007 16:12:25 +0200 Message-ID: <46641DC9.5050600@de.ibm.com> References: <1180613947.11133.58.camel@localhost.localdomain> <1180614044.11133.61.camel@localhost.localdomain> <1180614091.11133.63.camel@localhost.localdomain> <465EC637.7020504@de.ibm.com> <1180654765.10999.6.camel@localhost.localdomain> <465FC65C.6020905@de.ibm.com> <20070601131315.GW32105@kernel.dk> <4664164A.40604@de.ibm.com> <20070604134322.GC32105@kernel.dk> <1180965161.25878.47.camel@localhost.localdomain> <20070604135433.GG32105@kernel.dk> Reply-To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Jimi Xenidis , Stephen Rothwell , Xen Mailing List , "jmk-zzFmDc4TPjtKvsKVC3L/VUEOCMrvLtNR@public.gmane.org" , Herbert Xu , carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org, mschwid2-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, virtualization , kvm-devel , Suzanne McIntosh , Christian Borntraeger To: Jens Axboe Return-path: In-Reply-To: <20070604135433.GG32105-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Jens Axboe wrote: > Most people should not fiddle with it, the defaults are there for good > reason. I can provide a blk_queue_unplug_thresholds(q, depth, delay) > helper that you could use for the virtualized drivers, perhaps that > would be better for that use? Yea, we should'nt change the defaults without a good reason. That would change things for all device drivers. This interface provides all functionality we need. I think we need a knob in /sys/block/mydevice/queue/ in addition to that. so long, Carsten ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/