public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Luca Tettamanti <kronos.it-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel-TtF/mJH4Jtrk1uMJSBkQmQ@public.gmane.org,
	qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org
Subject: Re: PIIX/IDE: ports disabled in PCI config space?
Date: Tue, 05 Jun 2007 14:52:38 +0300	[thread overview]
Message-ID: <46654E86.8010103@qumranet.com> (raw)
In-Reply-To: <20070604205159.GB18668-sTXFmx6KbOnUXq0IF5SVAZ4oGUkBHcCu@public.gmane.org>

Luca Tettamanti wrote:
> Hello,
> I'm testing the new Fedora7 under KVM. As you may know Fedora has
> migrated to the new libata drivers.
>
> ata_piix is unhappy with the PIIX IDE controller provided by QEmu/KVM:
>
>
>   

[...]

> The following patch fixes the problem (i.e. ata_piix finds both the HD
> and the cdrom):
>
> --- a/hw/ide.c	2007-06-04 19:34:25.000000000 +0200
> +++ b/hw/ide.c	2007-06-04 21:45:28.000000000 +0200
> @@ -2586,6 +2586,8 @@ static void piix3_reset(PCIIDEState *d)
>      pci_conf[0x06] = 0x80; /* FBC */
>      pci_conf[0x07] = 0x02; // PCI_status_devsel_medium
>      pci_conf[0x20] = 0x01; /* BMIBA: 20-23h */
> +    pci_conf[0x41] = 0x80; // enable port 0
> +    pci_conf[0x43] = 0x80; // enable port 1
>  }
>  
>  void pci_piix_ide_init(PCIBus *bus, BlockDriverState **hd_table, int devfn)
>   

I imagine the reset state in the spec is disabled?  If so, then the 
long-term fix is to enable these bits in the bios.

In any case, I applied this to the kvm repo.  Thanks.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

  parent reply	other threads:[~2007-06-05 11:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-04 20:51 PIIX/IDE: ports disabled in PCI config space? Luca Tettamanti
     [not found] ` <20070604205159.GB18668-sTXFmx6KbOnUXq0IF5SVAZ4oGUkBHcCu@public.gmane.org>
2007-06-05 11:52   ` Avi Kivity [this message]
     [not found]     ` <46654E86.8010103-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-06-05 13:09       ` Luca
     [not found]         ` <68676e00706050609o10d0aa4fw8fbd7c850d0391f2-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-06-05 13:19           ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46654E86.8010103@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=kronos.it-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=kvm-devel-TtF/mJH4Jtrk1uMJSBkQmQ@public.gmane.org \
    --cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox