Re: [PATCH] implement pop reg in x86_emulate

Avi Kivity
2007-06-10T07:47:24Z

> Hi Avi,
> I am in the middle of implementing the big real support in the KVM
> now. I am trying to boot SuseLinux 10.1 on KVM, which uses extensive
> big real mode code in the boot loader. If you have any other targeted
> guests using big real mode do let me know.
> I have been working on my own private tree for a while. I sync it
> with the KVM tree every day. I have lots of debug code in the
> infrastructure part of the big-real mode support. Also I think I may
> need to extend/change it further to support more instructions. So I
> plan to hold the infrastructure patches for now. Meanwhile I have
> implemented emulation of the needed instructions. As it is well
> contained and should not affect any code path, this instruction
> implementation can go upstream right away,
> Attached is a patch for the "pop reg" instruction emulation. I will
> be sending more of such instruction emulation patches very soon, I
> just need to break them apart from my debug tree. Do provide me if you
> have any feedback on these. And once I get the big-real mode support
> working well enough, I will start cleaning the remaining code from
> debug statements, and start pushing that code in patches to you.

Great, fixing real mode is very important.

The patch looks ok, but it is whitespace-damaged. Please use
scripts/checkpatch.pl to check patches before sending. It is also in
dos file format (crlf).

--
error compiling committee.c: too many arguments to function