From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [kvm-devel] [PATCH] KVM - Fix rmode_tss_base declaration Date: Sun, 10 Jun 2007 10:36:01 +0300 Message-ID: <466BA9E1.6040909@qumranet.com> References: <20070606191925.GA8989@c2.user-mode-linux.org> <20070607031103.GA12462@c2.user-mode-linux.org> <4667931C.8070007@qumranet.com> <20070608194441.GA8169@c2.user-mode-linux.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "Li, Xin B" , kvm-devel@lists.sourceforge.net, LKML To: Jeff Dike Return-path: In-Reply-To: <20070608194441.GA8169@c2.user-mode-linux.org> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Jeff Dike wrote: > On Thu, Jun 07, 2007 at 08:09:48AM +0300, Avi Kivity wrote: > >> Some extra logic is needed on i386 with >= 4GB. Current code will >> wraparound since gfn_t is 32-bits long, but casting it to 64-bits is not >> the answer since the processor will truncate it back to 32 bits (the >> return value is eventually used as a long in enter_rmode()). >> > > Is it necessary to initialize TR in enter_rmode? I can't see anything > that says it has any meaning in real mode. > > VT doesn't support real mode. kvm uses virtual-8086 mode to virtualize real mode. Virtual 8086 mode does require a task state segment. -- error compiling committee.c: too many arguments to function