From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: 2.6.22-rc4-mm2: kvm compile breakage with X86_CMPXCHG64=n Date: Tue, 12 Jun 2007 09:00:17 +0300 Message-ID: <466E3671.2080103@qumranet.com> References: <20070606220313.8f7c1fab.akpm@linux-foundation.org> <20070612000718.GS3588@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Andrew Morton , linux-kernel@vger.kernel.org, kvm-devel@lists.sourceforge.net To: Adrian Bunk Return-path: In-Reply-To: <20070612000718.GS3588@stusta.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org Adrian Bunk wrote: > On Wed, Jun 06, 2007 at 10:03:13PM -0700, Andrew Morton wrote: > =20 >> ... >> Changes since 2.6.22-rc4-mm1: >> ... >> git-kvm.patch >> ... >> git trees >> ... >> =20 > > I'm getting the following compile error with CONFIG_X86_CMPXCHG64=3Dn= =20 > (with -Werror-implicit-function-declaration - otherwise it would be a= =20 > link error): > > <-- snip --> > > ... > CC [M] drivers/kvm/mmu.o > /home/bunk/linux/kernel-2.6/linux-2.6.22-rc4-mm2/drivers/kvm/mmu.c: I= n function =E2=80=98set_shadow_pte=E2=80=99: > /home/bunk/linux/kernel-2.6/linux-2.6.22-rc4-mm2/drivers/kvm/mmu.c:19= 9: error: implicit declaration of function =E2=80=98set_64bit=E2=80=99 > make[3]: *** [drivers/kvm/mmu.o] Error 1 > > <-- snip --> > =20 I've committed the following, which should disable kvm on i486 and belo= w: diff --git a/drivers/kvm/Kconfig b/drivers/kvm/Kconfig index 2f661e5..33fa28a 100644 --- a/drivers/kvm/Kconfig +++ b/drivers/kvm/Kconfig @@ -11,6 +11,7 @@ if VIRTUALIZATION config KVM tristate "Kernel-based Virtual Machine (KVM) support" depends on X86 && EXPERIMENTAL + depends on X86_CMPXCHG64 || 64BIT ---help--- Support hosting fully virtualized guest machines using hardwa= re virtualization extensions. You will need a fairly recent --=20 Do not meddle in the internals of kernels, for they are subtle and quic= k to panic.