Re: SMP guest boots

Li, Xin B
2007-06-13T12:53:55Z

>Hi Xin,
> Nice work! I am bummed that you are getting to do all the fun
>parts :)
>
>I have one comment:
>
>+ while (1) {
>+ if (vcpu->init_sipi_sipi_state ==
>+ KVM_VCPU_INIT_SIPI_SIPI_STATE_NORM)
>+ break;
>+ yield();
>+ }
>

Yeah, quick and dirty way, I will polish later maybe using completion.

>I would do this as a wait-queue instead of yielding (like how I
>implemented HLT, for instance).
>
>> My base is Greg's APIC patch version 9 with some collision fixes,
>
>were these actual fixes for the apic code, or just merge fixes between
>your work and mine? If the former, please send the patches
>for the apic fixes separately so we can apply them to the lapic branch.
>

Just merge fixes, your APIC patch is really good in quality.
-Xin