public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Luca Tettamanti <kronos.it-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel-TtF/mJH4Jtrk1uMJSBkQmQ@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [BUG] Oops with KVM-27
Date: Thu, 14 Jun 2007 11:26:29 +0300	[thread overview]
Message-ID: <4670FBB5.70707@qumranet.com> (raw)
In-Reply-To: <20070613204948.GA14710-sTXFmx6KbOnUXq0IF5SVAZ4oGUkBHcCu@public.gmane.org>

Luca Tettamanti wrote:
> With GOOD_APIC apic_read_around is a nop, while apic_write_around is a
> normal write. With !GOOD_APIC apic_write_around writes to the APIC reg
> using xchg. With !GOOD_APIC and this patch:
>
> --- include/asm-i386/apic.h~	2007-04-26 05:08:32.000000000 +0200
> +++ include/asm-i386/apic.h	2007-06-13 22:35:00.000000000 +0200
> @@ -56,7 +56,8 @@
>  static __inline fastcall void native_apic_write_atomic(unsigned long reg,
>  						       unsigned long v)
>  {
> -	xchg((volatile unsigned long *)(APIC_BASE+reg), v);
> +//	xchg((volatile unsigned long *)(APIC_BASE+reg), v);
> +	*((volatile unsigned long *)(APIC_BASE+reg)) = v;
>  }
>  
>  static __inline fastcall unsigned long native_apic_read(unsigned long reg)
>
> The kernel boots fine. 
>   

Looking at the xchg emulation code, it seems fine, but clearly it 
isn't.  Can you add logging to the kernel apic driver and to the qemu 
device emulation (qemu/hw/apic.c, apic_mem_readl()/apic_mem_writel()) 
and compare the results?

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/

  parent reply	other threads:[~2007-06-14  8:26 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-03 21:34 [BUG] Oops with KVM-27 Luca Tettamanti
     [not found] ` <20070603213432.GA3075-sTXFmx6KbOnUXq0IF5SVAZ4oGUkBHcCu@public.gmane.org>
2007-06-04  9:35   ` Avi Kivity
     [not found]     ` <4663DCE9.3000107-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-06-04 20:22       ` Luca Tettamanti
     [not found]     ` <20070604202248.GA18668@dreamland.darkstar.lan>
     [not found]       ` <20070604202248.GA18668-sTXFmx6KbOnUXq0IF5SVAZ4oGUkBHcCu@public.gmane.org>
2007-06-04 20:51         ` Avi Kivity
     [not found]       ` <46647B3E.2090205@qumranet.com>
     [not found]         ` <46647B3E.2090205-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-06-04 21:22           ` Luca Tettamanti
     [not found]             ` <20070604212207.GA22365-sTXFmx6KbOnUXq0IF5SVAZ4oGUkBHcCu@public.gmane.org>
2007-06-05  7:27               ` Avi Kivity
     [not found]                 ` <46651069.5040003-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-06-07 19:16                   ` Luca
     [not found]                     ` <68676e00706071216i4bd051c5hb1c114f3c13ab97f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-06-10 12:22                       ` Avi Kivity
     [not found]                     ` <466BED18.5040708@qumranet.com>
     [not found]                       ` <466BED18.5040708-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-06-10 20:54                         ` Luca
     [not found]                       ` <68676e00706101354n5fe7e1a9y12cb690cae2924e3@mail.gmail.com>
     [not found]                         ` <68676e00706101354n5fe7e1a9y12cb690cae2924e3-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-06-11  7:44                           ` Avi Kivity
     [not found]                         ` <466CFD6D.2080201@qumranet.com>
     [not found]                           ` <466CFD6D.2080201-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-06-11 21:06                             ` Luca
2007-06-12 17:52                             ` Luca Tettamanti
     [not found]                           ` <68676e00706111406r16eafd0eseaf1fb24f5c0d075@mail.gmail.com>
     [not found]                             ` <68676e00706111406r16eafd0eseaf1fb24f5c0d075-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-06-12  6:44                               ` Avi Kivity
     [not found]                           ` <20070612175246.GA5864@dreamland.darkstar.lan>
     [not found]                             ` <20070612175246.GA5864-sTXFmx6KbOnUXq0IF5SVAZ4oGUkBHcCu@public.gmane.org>
2007-06-13  8:59                               ` Avi Kivity
     [not found]                             ` <466FB1ED.3090905@qumranet.com>
     [not found]                               ` <466FB1ED.3090905-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-06-13 20:49                                 ` Luca Tettamanti
     [not found]                                   ` <20070613204948.GA14710-sTXFmx6KbOnUXq0IF5SVAZ4oGUkBHcCu@public.gmane.org>
2007-06-14  8:26                                     ` Avi Kivity [this message]
     [not found]                                       ` <4670FBB5.70707-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-06-14 22:33                                         ` Luca Tettamanti
2007-06-14 22:53                                       ` [kvm-devel] " Luca Tettamanti
2007-06-14 23:13                                         ` Luca Tettamanti
2007-06-14 23:27                                           ` Luca
     [not found]                                             ` <68676e00706141627s3cb87391sa0ee6711d2f7933f-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-06-15  9:06                                               ` Avi Kivity
2007-06-15 21:49                                                 ` [kvm-devel] " Luca Tettamanti
     [not found]                                                   ` <20070615214915.GA10536-sTXFmx6KbOnUXq0IF5SVAZ4oGUkBHcCu@public.gmane.org>
2007-06-16  7:43                                                     ` Avi Kivity
     [not found]                                                       ` <4673949B.1070505-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-06-17 15:14                                                         ` Luca Tettamanti
2007-06-17 15:24                                                           ` [kvm-devel] " Avi Kivity
2007-06-17 16:52                                                             ` [PATCH 1/2] kvm: Fix x86 emulator writeback Luca Tettamanti
     [not found]                                                               ` <20070617165201.GA23885-sTXFmx6KbOnUXq0IF5SVAZ4oGUkBHcCu@public.gmane.org>
2007-06-17 16:58                                                                 ` Avi Kivity
2007-06-18 10:07                                                                 ` Avi Kivity
     [not found]                                                                   ` <46765954.60102-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-06-18 11:32                                                                     ` Avi Kivity
     [not found]                                                                       ` <46766D57.8040206-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-06-19 20:25                                                                         ` Luca Tettamanti
     [not found]                                                                           ` <20070619202524.GA17672-sTXFmx6KbOnUXq0IF5SVAZ4oGUkBHcCu@public.gmane.org>
2007-06-19 20:41                                                                             ` Luca Tettamanti
     [not found]                                                                               ` <20070619204120.GA18800-sTXFmx6KbOnUXq0IF5SVAZ4oGUkBHcCu@public.gmane.org>
2007-06-20  7:47                                                                                 ` Avi Kivity
2007-06-19 20:41                                                                             ` [PATCH 2/2] kvm: avoid useless memory write when possible Luca Tettamanti
2007-06-17 16:52                                                             ` Luca Tettamanti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4670FBB5.70707@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=kronos.it-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=kvm-devel-TtF/mJH4Jtrk1uMJSBkQmQ@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox