From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [BUG] Oops with KVM-27 Date: Thu, 14 Jun 2007 11:26:29 +0300 Message-ID: <4670FBB5.70707@qumranet.com> References: <20070604202248.GA18668@dreamland.darkstar.lan> <46647B3E.2090205@qumranet.com> <20070604212207.GA22365@dreamland.darkstar.lan> <46651069.5040003@qumranet.com> <68676e00706071216i4bd051c5hb1c114f3c13ab97f@mail.gmail.com> <466BED18.5040708@qumranet.com> <68676e00706101354n5fe7e1a9y12cb690cae2924e3@mail.gmail.com> <466CFD6D.2080201@qumranet.com> <20070612175246.GA5864@dreamland.darkstar.lan> <466FB1ED.3090905@qumranet.com> <20070613204948.GA14710@dreamland.darkstar.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-TtF/mJH4Jtrk1uMJSBkQmQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Luca Tettamanti Return-path: In-Reply-To: <20070613204948.GA14710-sTXFmx6KbOnUXq0IF5SVAZ4oGUkBHcCu@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Luca Tettamanti wrote: > With GOOD_APIC apic_read_around is a nop, while apic_write_around is a > normal write. With !GOOD_APIC apic_write_around writes to the APIC reg > using xchg. With !GOOD_APIC and this patch: > > --- include/asm-i386/apic.h~ 2007-04-26 05:08:32.000000000 +0200 > +++ include/asm-i386/apic.h 2007-06-13 22:35:00.000000000 +0200 > @@ -56,7 +56,8 @@ > static __inline fastcall void native_apic_write_atomic(unsigned long reg, > unsigned long v) > { > - xchg((volatile unsigned long *)(APIC_BASE+reg), v); > +// xchg((volatile unsigned long *)(APIC_BASE+reg), v); > + *((volatile unsigned long *)(APIC_BASE+reg)) = v; > } > > static __inline fastcall unsigned long native_apic_read(unsigned long reg) > > The kernel boots fine. > Looking at the xchg emulation code, it seems fine, but clearly it isn't. Can you add logging to the kernel apic driver and to the qemu device emulation (qemu/hw/apic.c, apic_mem_readl()/apic_mem_writel()) and compare the results? -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/