From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: kvm-intel kernel panicing 2.6.22 on T7200 Date: Fri, 15 Jun 2007 13:02:50 +0300 Message-ID: <467263CA.1070507@qumranet.com> References: <1181830231.9941.13.camel@linux> <1181831139.13335.14.camel@ghaskins-t60p.haskins.net> <1181833614.6533.2.camel@linux> <1181834264.13335.18.camel@ghaskins-t60p.haskins.net> <1181835974.7023.1.camel@linux> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070304010303020805000701" Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Magicboiz Return-path: In-Reply-To: <1181835974.7023.1.camel@linux> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is a multi-part message in MIME format. --------------070304010303020805000701 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Magicboiz wrote: > with VNC option, we had better luck: we got an Oops!!: > > Jun 14 17:37:35 linux kernel: [ 575.212000] BUG: unable to handle > kernel NULL pointer dereference at virtual address 00000024 > Jun 14 17:37:35 linux kernel: [ 575.212000] EIP is at mmu_free_roots > +0x54/0x90 [kvm] > Does the attached patch help? (cd to kernel/ and apply with 'patch -p3') -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. --------------070304010303020805000701 Content-Type: text/x-patch; name="use-zero-consistently-for-missing-shadow-pdpts.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename*0="use-zero-consistently-for-missing-shadow-pdpts.patch" diff --git a/drivers/kvm/mmu.c b/drivers/kvm/mmu.c index ad50cfd..f4cb731 100644 --- a/drivers/kvm/mmu.c +++ b/drivers/kvm/mmu.c @@ -859,7 +859,7 @@ static void mmu_free_roots(struct kvm_vcpu *vcpu) page = page_header(root); --page->root_count; } - vcpu->mmu.pae_root[i] = INVALID_PAGE; + vcpu->mmu.pae_root[i] = 0; } vcpu->mmu.root_hpa = INVALID_PAGE; } @@ -888,12 +888,10 @@ static void mmu_alloc_roots(struct kvm_vcpu *vcpu) for (i = 0; i < 4; ++i) { hpa_t root = vcpu->mmu.pae_root[i]; - ASSERT(!VALID_PAGE(root)); + ASSERT(!root); if (vcpu->mmu.root_level == PT32E_ROOT_LEVEL) { - if (!is_present_pte(vcpu->pdptrs[i])) { - vcpu->mmu.pae_root[i] = 0; + if (!is_present_pte(vcpu->pdptrs[i])) continue; - } root_gfn = vcpu->pdptrs[i] >> PAGE_SHIFT; } else if (vcpu->mmu.root_level == 0) root_gfn = 0; @@ -1241,7 +1239,7 @@ static int alloc_mmu_pages(struct kvm_vcpu *vcpu) goto error_1; vcpu->mmu.pae_root = page_address(page); for (i = 0; i < 4; ++i) - vcpu->mmu.pae_root[i] = INVALID_PAGE; + vcpu->mmu.pae_root[i] = 0; return 0; --------------070304010303020805000701 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ --------------070304010303020805000701 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --------------070304010303020805000701--